Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Related: #430 (background).
Manifest file cache hits currently read Arrow IPC batches and inspect partition fields row by row. Snapshot live-entry caches separately serialize merged entries. This change introduces a shared
IndexedManifestEntriesrepresentation so both paths can skip unmatched partition/bucket groups before constructingManifestEntryandDataFileMetaobjects.SnapshotLiveManifestEntries, retaining its bucket-level keys, snapshot retention, and merged live-entry semantics.Cold cache loads still read the complete manifest. Manifest-list and index-manifest caches continue to use Arrow IPC. This draft does not claim a measured performance improvement; benchmarks remain to be run.
Tests
Added coverage for partition/bucket pruning, interleaved ADD/DELETE ordering, inferred bucket layouts, snapshot reuse, malformed envelopes, complete-file reuse across readers and filters, and predicate error propagation. Updated existing cache lifetime, admission, concurrency, and memory accounting tests.
Validation completed locally:
cmake --build build --target paimon-core-test -j 16— passed../build/debug/paimon-core-test— 2,364 tests passed before the final row-range overflow-expression correction../build/debug/paimon-core-test --gtest_filter='*Manifest*:*FileStoreScan*:*InferredBucket*'— 131 tests passed after that final correction and rebuild.pre-commit run --filesfor all 17 changed files — passed.git diff --check— passed.The standalone integration suite and performance benchmarks have not been run.
API and Format
No changes to public headers under
include/paimon, configuration options, persisted manifest formats, or protocols. Existing cache kinds and keys are retained. Private data-manifest and snapshot-live cache encodings change; incompatible cached values are rebuilt from the source. File and snapshot caches remain separate logical cache layers using a shared representation.Documentation
Updated
docs/source/user_guide/manifest_cache.rstanddocs/source/user_guide/manifest_entry_cache.rstto describe the shared indexed representation, filtering, cache fallback, and memory accounting.Generative AI tooling
Generated-by: OpenAI Codex CLI 0.163.0 (GPT-6)