Repository navigation
feat(scan): support cooperative append-only planning cancellation - #440
Draft
realAaronWu wants to merge 6 commits into
Draft
realAaronWu wants to merge 6 commits into
realAaronWu wants to merge 6 commits into
Conversation
Contributor
Author
|
Could a maintainer approve the fork workflow runs for exact PR440 head These runs currently report
Independent local review cleared this exact commit for validation-Draft publication only. The PR remains Draft pending actual revised-head CI and final delivery review; prior ff6f275 CI is not a substitute. This updates the existing approval request rather than adding a duplicate. |
Contributor
Author
|
CPU CI for the updated validation draft ( |
Collaborator
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Purpose
Refs #435. Add an optional query-scoped cancellation token to batch metadata
planning, with cooperative checkpoints and reader/Arrow-root cleanup. A cancelled
scan must not affect another scan or publish a partial plan.
Preserve main's selected-row/lazy reads and cache candidate accounting while
carrying cancellation through predicates, deserialization and entry consumers.
Includes selected-row regressions and removes the test-only debugger hook.
Validation Draft: runtime qualification is incomplete; not requesting Ready
or upstream review. Current head
40835b3dincludes the maintainer's merge ofmain
e7ec679a; the earlier reviewed feature head wase8121470.Validation
inventory, public-token concurrency, token mutation and Mac token TSan. These
do not qualify the full planner/library or the new toolchain inputs.
nested Thrift download. Complete native/planner regression, guard mutations
and scoped Linux sanitizers remain pending, not merely GPU-only pending.
as qualification of this revision. Actual enabled compiler/architecture/backend
and sanitizer jobs must execute and their evidence must be checked.
stablechannel for Vortex. Actual resolved toolchains need CI evidence; theinterrupted local default build did not exercise these optional backends.
Boundaries
Cancellation cannot preempt filesystem/decoder calls and has no latency guarantee.
Token planning runs synchronously and bypasses shared caches. Active embedded
indexes with a token are explicitly unsupported. Ordinary no-token planning is
preserved; Arrow error-root cleanup also applies without a token.
Library and consumer need a paired rebuild; default arguments do not establish
binary ABI compatibility. No storage-format change or Paimon GPU scan claim.
Generative AI Tooling
Generated-by: OpenAI Codex (desktop session; runtime version not exposed)