Repository navigation
system/nxinit: Revert "Give the builtin list to the kernel" - #3914
Merged
casaroli merged 1 commit intoOct 25, 2026
Merged
Conversation
This reverts commit d9454d8. apache/nuttx#20964 removed BOARDIOC_BUILTINS and struct boardioc_builtin_s, so nxinit no longer builds in a protected build: init.c:214:29: error: storage size of 'builtin' isn't known init.c:218:12: error: 'BOARDIOC_BUILTINS' undeclared (first use in this function) Assisted-by: Kiro:claude-opus-5.5 Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
xiaoxiang781216
marked this pull request as ready for review
October 25, 2026 12:46
xiaoxiang781216
approved these changes
Oct 25, 2026
casaroli
approved these changes
Oct 25, 2026
This was referenced Oct 25, 2026
Merged
cederom
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert #3907. apache/nuttx#20964 removed
BOARDIOC_BUILTINS; the protected kernel now reads the builtin list throughstruct userspace_s, so nxinit no longer needs to register it.Impact
Fixes the protected-build break of
system/nxinit(e.g.rv-virt:pnsh,esp32s3-devkit:knsh).Testing
esp32s3-devkit:knshwith nuttx master345643d5ae4:Before:
After: builds cleanly.