Skip to content

Revert "apps: Print the revents field of struct pollfd without a cast." - #3909

Merged
acassis merged 1 commit into
apache:masterfrom
casaroli:revert-3888-pollfd-revents-nocast
Oct 24, 2026
Merged

acassis merged 1 commit into
apache:masterfrom
casaroli:revert-3888-pollfd-revents-nocast

Conversation

@casaroli

@casaroli casaroli commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Reverts #3888 that was prematurely merged by @acassis with failed CI jobs.

@cederom cederom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@casaroli please fill in the PR details with required information - why this revert is needed, what it fixes, etc.

Please bear in mind that you are reverting your own PR. This cost us precious CI resources. Looks like you did not test big changes locally on your own repo / environment. The upstream repo is NOT a testing platform. WE MAY LOOSE CI COMPLETELY!!

@acassis

acassis commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

@casaroli please fill in the PR details with required information - why this revert is needed, what it fixes, etc.

Please bear in mind that you are reverting your own PR. This cost us precious CI resources. Looks like you did not test big changes locally on your own repo / environment. The upstream repo is NOT a testing platform. WE MAY LOOSE CI COMPLETELY!!

@cederom actually it was my fault, I merged it without respecting the depends-on

@cederom

cederom commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

@cederom: > @casaroli please fill in the PR details with required information - why this revert is needed, what it fixes, etc.

Please bear in mind that you are reverting your own PR. This cost us precious CI resources. Looks like you did not test big changes locally on your own repo / environment. The upstream repo is NOT a testing platform. WE MAY LOOSE CI COMPLETELY!!

@acassis: @cederom actually it was my fault, I merged it without respecting the depends-on

Allright let's save the world then :D

Folks we really need to mind the CI use - we already got warning from ASF that we have over more 50% use than 2nd ASF project last week.. and we really may loose CI :-(

@cederom

cederom commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Now we have ci/check failed o_O

@acassis
acassis merged commit d47c7a9 into apache:master Oct 24, 2026
33 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants