Repository navigation
system/fastboot: fix the sparse chunk walk - #3903
Merged
xiaoxiang781216 merged 1 commit intoOct 24, 2026
Merged
Conversation
DONT_CARE must advance the output offset or later chunks land on earlier ones; CRC32 chunks carry 4 bytes to skip; FILL data is little-endian. Assisted-by: OpenCode:mimo-v2.6-pro Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
xiaoxiang781216
approved these changes
Oct 23, 2026
JianyuWang0623
marked this pull request as ready for review
October 23, 2026 11:14
acassis
approved these changes
Oct 23, 2026
jerpelea
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix three bugs in the sparse chunk walk of
fastboot_flash_program():le32toh(); the sparse format is little-endian.Impact
Sparse images flashed via fastbootd are no longer corrupted. No API or build change.
Testing
sim:nsh+CONFIG_SYSTEM_FASTBOOTD=ybuilds clean. Flashed onlckfb-szpi-esp32s3:fastbootwithfastboot flash ram1 sparse_test.img, thenread back with
hexdump.Test image (
blk_sz4096): RAW, DONT_CARE, FILL0x11223344, CRC32, RAW.Expected: RAW1 at 0, hole at 4096, FILL at 8192, RAW2 at 12288.
Before:
After: