Repository navigation
netutils/dropbear: fix CMake build target names, scp includes, and main alias. - #3841
Merged
xiaoxiang781216 merged 1 commit intoOct 13, 2026
Merged
Conversation
…in alias - Use apps_<name> target names for target_include_directories, target_compile_definitions, and target_compile_options. - Add missing libtomcrypt and libtommath include directories and definitions for apps_scp. - Use set_property(... APPEND ...) on dropbear/src/scp.c so the main=scp_main alias is preserved. - Place dropbear_main.c as the first source in SRCS so nuttx_add_application assigns the main alias to it. - Remove duplicate target_sources(apps PRIVATE). Fixes apache#3834 Signed-off-by: Sarthak Pandey <sarthak@email.com>
Sarthak-Pandey
force-pushed
the
fix/dropbear-cmake-build
branch
from
October 12, 2026 18:38
750cf3a to
e09fe73
Compare
cederom
changed the title
Contributor
|
@acassis could you please take a look + the initial dopbear dev from gsoc? :-) |
1 task done
acassis
approved these changes
Oct 13, 2026
xiaoxiang781216
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CMake build failures for Dropbear and SCP applications described in #3834:
apps_${PROGNAME}andapps_scptarget names for target_include_directories, target_compile_definitions, and target_compile_options.libtomcrypt/src/headersandlibtommathinclude paths and crypto definitions forapps_scp.set_property(... APPEND ...)ondropbear/src/scp.cso themain=scp_mainalias is preserved.dropbear_main.cas the first source inSRCSsonuttx_add_applicationassigns themainalias to it.target_sources(apps PRIVATE ${DROPBEAR_SRCS}).Impact
Enables building Dropbear and SCP using CMake (previously only Make worked).
Testing
Tested with CMake:
cmake -B build -DBOARD_CONFIG=esp32c3-devkit:dropbear -GNinjacmake --build buildFixes #3834