Skip to content

[IT] Force English locale for integration test JVMs - #19068

Open
chrisdutz wants to merge 1 commit into
masterfrom
fix/it-force-english-locale
Open

chrisdutz wants to merge 1 commit into
masterfrom
fix/it-force-english-locale

Conversation

@chrisdutz

Copy link
Copy Markdown
Contributor

Integration tests fail on hosts with a non-English default locale (e.g. de_DE): String.format("%f") in tests renders decimal commas into SQL, and server-side number formatting (format(), UDF output) differs from the expected English output.

Export -Duser.language=en -Duser.country=US as JAVA_TOOL_OPTIONS via failsafe's environmentVariables. The forked test JVM picks it up directly and the DataNode/ConfigNode processes spawned by AbstractNodeWrapper inherit it through ProcessBuilder. The value is configurable via the integrationTest.localeOpts property.

Integration tests fail on hosts with a non-English default locale (e.g.
de_DE): String.format("%f") in tests renders decimal commas into SQL, and
server-side number formatting (format(), UDF output) differs from the
expected English output.

Export -Duser.language=en -Duser.country=US as JAVA_TOOL_OPTIONS via
failsafe's environmentVariables. The forked test JVM picks it up directly
and the DataNode/ConfigNode processes spawned by AbstractNodeWrapper
inherit it through ProcessBuilder. The value is configurable via the
integrationTest.localeOpts property.
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.05%. Comparing base (3a51384) to head (69e2003).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #19068   +/-   ##
=========================================
  Coverage     48.05%   48.05%           
  Complexity      604      604           
=========================================
  Files          5572     5572           
  Lines        410194   410195    +1     
  Branches      54112    54112           
=========================================
+ Hits         197110   197128   +18     
+ Misses       213084   213067   -17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants