Repository navigation
[To dev/1.3] [Pipe] Improve legacy receiver error messages and diagnostics (#18932) - #18949
Merged
Merged
Conversation
…stics Backport the Pipe portion of 86ae957 (apache#18932), including localized diagnostics and regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport the Pipe portion of #18932 (86ae957) to
dev/1.3.Legacy Pipe receiver failures now retain the exception stack trace and return the same formatted diagnostic to the sender. File-resolution failures identify the file; append failures include the file name, requested offset, and byte count. Existing status codes and numeric offset-redirection responses are preserved.
Add matching English and Chinese
DataNodePipeMessagescontaining only the four legacy receiver templates, and backport the write-failure regression test and updated path-validation assertions. Adapt those assertions to the existingdev/1.3file-validation messages. Subscription changes are excluded.Validation
mvn -nsu test-compile -DskipTests, with the default locale and with-P with-zh-locale.IoTDBLegacyPipeReceiverAgentTest: 4 tests passed in each locale, using-pl iotdb-core/datanode -am test -Dtest=IoTDBLegacyPipeReceiverAgentTest -Dsurefire.failIfNoSpecifiedTests=false.git diff --checkpassed.This PR has: