Repository navigation
[To dev/1.3] [Fix] Guard stopped ConfigNode Pipe polling (#18913) - #18922
Merged
Merged
Conversation
Partially backport 4943c73. Check the stop flag before and after polling, retain fetched events for restart, and release events returned after the task is dropped. Adapt the regression tests to the 1.3 extractor and outputPipeConnector fields. The LOAD retention changes do not apply because 1.3 sends LOAD payloads and terminal commands directly to all replicas instead of replicating staged-payload references through the WAL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport the ConfigNode fix from #18913 (
4943c730d7aac7612b6a5c700625e94628a970cb) todev/1.3.When
STOP PIPEfinishes while a ConfigNode subtask is waiting inextractor.supply(), the subtask can still transfer the returned event. Check the stop flag before polling and again after polling returns. Retain the fetched event for restart, and release it without committing if the task was dropped during polling.Adapt the regression tests to the 1.3 field names,
extractorandoutputPipeConnector.Backport scope
The LOAD retention changes from #18913 do not apply to this branch. In
dev/1.3,LoadTsFileDispatcherImplsends pieces and terminal commands directly to every replica. The branch does not containLoadTsFileConsensusNode,LoadTaskRetention, orLoadTsFileCleaner, or the staged-payload WAL references addressed by the original fix.Validation
dev/1.3implementation.PipeConfigNodeSubtaskTestandPipeConfigNodeSubtaskExecutorTestpass: 8 tests, no failures or errors. Dependencies, including Thrift sources, are built from this branch using the reactor.git diff --checkpass.This PR has: