Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Shared Pipe, IoTConsensus, and subscription code has diverged structurally between upstream and downstream, creating avoidable merge conflicts. Align the common interfaces, helper methods, and names while preserving the current open-source behavior.
PipeBatchMetricsSettablefor sink and batch-builder metrics, and extract batch detachment without changing atomic ownership handoff.TableViewTabletProjectorProviderand extract consensus tablet pruning. Providers remain scoped to individual batches, preserving schema waits and the lifetime of each batch's cached projector.Existing public constructors and metric setters remain available. Serialization, column filtering, WAL retry protection, memory admission, and diagnostics retain their current behavior. Enterprise-specific functionality is outside this refactor.
Validation
mvn test-compile -DskipTests -Ddevelocity.off=true.mvn test-compile -DskipTests -P with-zh-locale -Ddevelocity.off=true.git diff --check.Focused regression command
This PR has: