Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18833 +/- ##
============================================
+ Coverage 45.91% 45.92% +0.01%
Complexity 712 712
============================================
Files 5502 5502
Lines 398775 398779 +4
Branches 51967 51969 +2
============================================
+ Hits 183080 183124 +44
+ Misses 215695 215655 -40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An oversized first deletion was acknowledged as
SUCCESSeven whenserializeDeletionToBatchBuffer()returnedfalse, leaving no recoverable DAL record. The deletion callers only propagateFAILURE, so they could continue with that false acknowledgment. Both log rotation paths also acknowledged a batch after closing its channel without callingforce(false).Reject an oversized first record through the existing persistence failure path before updating its progress index. Clear failed batch state so a later successful batch cannot acknowledge failed resources. Force the rotated log before closing it and delivering success, and propagate a force failure to the waiting callers. The new error message is provided in both locales.
#18662 is already merged in the base and fixes the close/flush accounting race; these serialization and rotation paths remain affected. Its regression test is retained.
Validation
All four new regression tests fail against the original master implementation and pass with this change. They cover an oversized first deletion followed by a recoverable valid deletion, force ordering on both rotation paths, and force failure followed by another batch.
Maven:
PageCacheDeletionBufferTest,DeletionResourceTest, andDeletionRecoverTest— 13 tests, 0 failures/errors/skips. Run with:mvn -pl iotdb-core/datanode -am test \ -Dtest=PageCacheDeletionBufferTest,DeletionResourceTest,DeletionRecoverTest \ -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false \ -Diotdb.test.skip=false -Diotdb.ut.skip=falseFull reactor English
mvn test-compile -DskipTests— passed (53 modules).Full reactor Chinese
mvn test-compile -P with-zh-locale -DskipTests— passed (53 modules).mvn -pl iotdb-core/datanode spotless:check checkstyle:check— passed;git diff --checkis clean. The locale message keys and format specifiers match.This PR has:
Key changed classes
PageCacheDeletionBuffer,PageCacheDeletionBufferTest, andDataNodePipeMessages(en/zh).