Skip to content

[Subscription] Limit DATE conversion to active tablet rows - #18832

Open
Caideyipi wants to merge 1 commit into
masterfrom
codex/consensus-date-rowcount
Open

Caideyipi wants to merge 1 commit into
masterfrom
codex/consensus-date-rowcount

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

ConsensusLogToTabletConverter converted DATE int[] columns across their full backing capacity. InsertTabletNode and RelationalInsertTabletNode can retain unused capacity beyond getRowCount(), where zero-filled DATE slots cause DateTimeParseException on the live consensus subscription path. Pass rowCount through both conversion paths and leave inactive slots null. Added tree/table regression tests with oversized backing arrays. Validation: mvn -o spotless:apply -pl iotdb-core/datanode; direct javac of the changed production/test classes; ConsensusLogToTabletConverterTest OK (17 tests). The full DataNode test-compile remains blocked by pre-existing local SNAPSHOT/generated dependency mismatches unrelated to this change.

@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.91%. Comparing base (932c1da) to head (5cb38ae).

Files with missing lines Patch % Lines
...roker/consensus/ConsensusLogToTabletConverter.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #18832   +/-   ##
=========================================
  Coverage     45.91%   45.91%           
  Complexity      712      712           
=========================================
  Files          5502     5502           
  Lines        398775   398775           
  Branches      51967    51967           
=========================================
+ Hits         183080   183099   +19     
+ Misses       215695   215676   -19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant