Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A transient
NoSuchFileExceptionduring the initial region-progress WAL lookup was treated as a locate failure and thrown frompoll, producingSUBSCRIPTION_POLL_ERROR(1904). This can interrupt consumers while a WAL filename is changing during rolling.Carry an explicit
RETRY_LATERdecision for deferred reads and leave prefetch initialization dormant until a subsequent poll completes the lookup. Recovery frontiers and the replay cursor are installed only after a successful lookup. Confirmed retained WAL corruption remains a lookup failure, including scans that also encounter a temporarily unreadable live file.The regression tests reproduce a file disappearing between directory listing and opening, repeated unreadable polls followed by recovery, retained corruption, and corruption followed by a deferred live-file read. Recovery checks verify that committed records are skipped and the remaining records replay exactly once without WAL gap increments.
Validation
mvn test-compile -DskipTestsandmvn test-compile -DskipTests -P with-zh-locale.This PR has:
Key changed/added classes
ConsensusPrefetchingQueue,ConsensusPrefetchingQueueInitializationTest