Repository navigation
[dev/1.3] Fix schema existence check fail-open behavior - #18827
Merged
Merged
Conversation
* Fix schema existence check fail-open behavior * Fix PR 18755 encoding and compilation issues (cherry picked from commit 0f91bed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport #18755 (commit
0f91bed7544464f3fcb7f46d3bdf8c50669ed9b8) todev/1.3.Schema existence checks now preserve failures instead of silently returning an empty result. PBTree treats
PathNotExistExceptionas a missing path and reports other metadata exceptions as validation errors. The Memory and PBTree schema-region wrappers no longer swallow unexpected exceptions.Resolve the Memory implementation conflict using the existing
mtreefield name indev/1.3.Validation
mvn spotless:apply -pl iotdb-core/datanode— passed.mvn test -pl iotdb-core/datanode -am -Dtest=SchemaRegionBasicTest,MTreeBelowSGMemoryImplTest,MTreeBelowSGCachedImplTest -Dsurefire.failIfNoSpecifiedTests=false— passed; 67 tests passed, 4 existing performance-test cases ignored via@Ignore.git diff --check origin/dev/1.3...HEAD— passed.Self-reviewed.