Repository navigation
IGNITE-29167 Use example file names as test_examples ids - #69
Conversation
The ids were the absolute path to each example script, so the test name depended on the build agent's work directory. On TeamCity, agents with different work roots gave the same test different names and histories. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
/runall |
|
@anton-vinogradov the verdict of your ❌ 3 blockers:
29 failing tests are not blamed on this PR. The checker's page lists them with their reasons. new test / no master history: master has no runs of the test on this JDK to compare with: a new test, or one master does not run. ♻️ Settled after one auto re-run: build 9432981 ran the suite again on the same commits. 📝 The JIRA visa is in IGNITE-29167. This run uses Ignite master at the commit above. If this PR needs an Ignite change that is not in that commit, the run tests this PR without that change. What each label means and what to do: verdict glossary. |
JIRA: https://issues.apache.org/jira/browse/IGNITE-29167
Problem
test_examplesis parametrized with the absolute path of each examplescript. pytest puts that path into the test id, so the test name depends on
the agent's work directory.
On ci2.ignite.apache.org ("Thin client: Python" in the RunAll chain) agents
have two different work roots, so one test has two names and two histories:
From 2026-10-03 to 2026-10-18, master ran
read_binary.py106 times:25 runs under the first name and 81 under the second. The same happens to all
13 example tests. Because of this:
failure, because TeamCity sees it as a different test.
Change
Use the script file name as the parameter id (
ids=os.path.basename). Thetest still runs the script by its full path. The TeamCity name becomes:
TeamCity will see the 13 example tests as new tests once, and their history
starts again from this change.
Testing
pytest --collect-only -q tests/test_examples.pyshows ids liketest_examples[read_binary.py]instead of the absolute path.TEAMCITY_VERSIONset, teamcity-messages reportstests.test_examples.test_examples(read_binary_py).flake8 tests/test_examples.pypasses.🤖 Generated with Claude Code