Remove deprecated lazy_fixture dependency #2743

Activity

1. raulcd commented on Nov 12, 2025

   

   raulcd

   on Nov 12, 2025

   MemberAuthor

   More actions

   @kevinjqliu I plan to work on this one, can you assign it to me please?

   I have tried a couple of approaches, we could do the following which isn't great because we lose some typing annotations for our test signatures but we could define when retrieving the fixture:

   @@ -193,17 +192,20 @@ def test_create_table_removes_trailing_slash_from_location(catalog: InMemoryCata
    @pytest.mark.parametrize(
        "schema,expected",
        [
   -        (lazy_fixture("pyarrow_schema_simple_without_ids"), lazy_fixture("iceberg_schema_simple_no_ids")),
   -        (lazy_fixture("iceberg_schema_simple"), lazy_fixture("iceberg_schema_simple")),
   -        (lazy_fixture("iceberg_schema_nested"), lazy_fixture("iceberg_schema_nested")),
   -        (lazy_fixture("pyarrow_schema_nested_without_ids"), lazy_fixture("iceberg_schema_nested_no_ids")),
   +        ("pyarrow_schema_simple_without_ids", "iceberg_schema_simple_no_ids"),
   +        ("iceberg_schema_simple", "iceberg_schema_simple"),
   +        ("iceberg_schema_nested", "iceberg_schema_nested"),
   +        ("pyarrow_schema_nested_without_ids", "iceberg_schema_nested_no_ids"),
        ],
    )
    def test_convert_schema_if_needed(
        schema: str,
        expected: str,
        catalog: InMemoryCatalog,
   +    request: pytest.FixtureRequest,
    ) -> None:
   +    schema: Schema | pa.Schema, = request.getfixturevalue(schema)
   +    expected: Schema = request.getfixturevalue(expected)
        assert expected == catalog._convert_schema_if_needed(schema)
   

   or we could create interim fixtures to maintain signatures, even though we create some functions that seem unnecessary

   +@pytest.fixture
   +def catalog(request: pytest.FixtureRequest) -> SqlCatalog:
   +    """Indirect fixture for catalog parametrization."""
   +    return request.getfixturevalue(request.param)
   +
   +
   +@pytest.fixture
   +def table_identifier(request: pytest.FixtureRequest) -> Identifier:
   +    """Indirect fixture for table_identifier parametrization."""
   +    return request.getfixturevalue(request.param)
   +
   +
   +@pytest.fixture
   +def namespace(request: pytest.FixtureRequest) -> tuple[str, ...]:
   +    """Indirect fixture for namespace parametrization."""
   +    return request.getfixturevalue(request.param)
   +
   +
   +@pytest.fixture
   +def from_table_identifier(request: pytest.FixtureRequest) -> Identifier:
   +    """Indirect fixture for from_table_identifier parametrization."""
   +    return request.getfixturevalue(request.param)
   +
   +
   +@pytest.fixture
   +def to_table_identifier(request: pytest.FixtureRequest) -> Identifier:
   +    """Indirect fixture for to_table_identifier parametrization."""
   +    return request.getfixturevalue(request.param)
   +
   +
   +@pytest.fixture
   +def table_identifier_1(request: pytest.FixtureRequest) -> Identifier:
   +    """Indirect fixture for table_identifier_1 parametrization."""
   +    return request.getfixturevalue(request.param)
   +
   +
   +@pytest.fixture
   +def table_identifier_2(request: pytest.FixtureRequest) -> Identifier:
   +    """Indirect fixture for table_identifier_2 parametrization."""
   +    return request.getfixturevalue(request.param)
   +
   +
    def test_creation_with_no_uri(catalog_name: str) -> None:
        with pytest.raises(NoSuchPropertyException):
            SqlCatalog(catalog_name, not_uri="unused")
   @@ -293,9 +334,10 @@ def test_creation_when_all_tables_exists(alchemy_engine: Engine, catalog_name: s
    @pytest.mark.parametrize(
        "catalog",
        [
   -        lazy_fixture("catalog_memory"),
   -        lazy_fixture("catalog_sqlite"),
   +        "catalog_memory",
   +        "catalog_sqlite",
        ],
   +    indirect=True,
    )
    def test_create_tables_idempotency(catalog: SqlCatalog) -> None:
        # Second initialization should not fail even if tables are already created
   @@ -306,16 +348,18 @@ def test_create_tables_idempotency(catalog: SqlCatalog) -> None:
    @pytest.mark.parametrize(
        "catalog",
        [
   -        lazy_fixture("catalog_memory"),
   -        lazy_fixture("catalog_sqlite"),
   +        "catalog_memory",
   +        "catalog_sqlite",
        ],
   +    indirect=True,
    )
    @pytest.mark.parametrize(
        "table_identifier",
        [
   -        lazy_fixture("random_table_identifier"),
   -        lazy_fixture("random_hierarchical_identifier"),
   +        "random_table_identifier",
   +        "random_hierarchical_identifier",
        ],
   +    indirect=True,
    )
    def test_create_table_default_sort_order(catalog: SqlCatalog, table_schema_nested: Schema, table_identifier: Identifier) -> None:
        namespace = Catalog.namespace_from(table_identifier)
   

   Which approach do you prefer.

   Based on some investigation it seems the second approach is the recommended one.
2. raulcd commented on Nov 13, 2025

   

   raulcd

   on Nov 13, 2025

   MemberAuthor

   More actions

   @Fokko FYI about the different approaches. I might go with the second but as there are hundreds of uses of lazy-fixture I was trying to get an agreement of the approach before having to go back and change all of them again :)
3. kevinjqliu commented on Nov 13, 2025

   

   kevinjqliu

   on Nov 13, 2025

   Contributor

   More actions

   hey @raulcd thanks for working on this.

   i like the second approach. It keeps the existing structure where we can define the fixtures once in conftest.py and reuse them in the function decorators

   ❤️React with ❤️1Reacted by Raúl Cumplido
4. kevinjqliu

   assigned

   raulcd

   on Nov 13, 2025
5. Fokko commented on Nov 13, 2025

   

   Fokko

   on Nov 13, 2025

   Contributor

   More actions

   Nice one @raulcd, I also prefer the second approach. Thanks for working on this 🙌
6. Fokko

   added a commit that references this issue on Feb 7, 2026

   infra: upgrade pytest and use pytest_lazy_fixtures (#2978)

   ...

   b98de51
7. github-actions commented on May 13, 2026

   

   github-actionsBot

   on May 13, 2026 – with GitHub Actions

   More actions

   This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
8. rambleraptor commented on May 13, 2026

   

   rambleraptor

   on May 13, 2026

   Collaborator

   More actions

   With the move over to pytest_lazy_fixtures and the upgrade to pytest 9.0.2, we can close this ticket.
9. raulcd commented on May 14, 2026

   

   raulcd

   on May 14, 2026

   MemberAuthor

   More actions

   I agree, closing
10. raulcd

    closed this as completedon May 14, 2026