Skip to content

fix(ci): scope PR tests to relevant workflow changes - #1048

Merged
wgtmac merged 1 commit into
apache:mainfrom
manuzhang:codex/scope-pr-test-workflow-filters
Oct 22, 2026
Merged

wgtmac merged 1 commit into
apache:mainfrom
manuzhang:codex/scope-pr-test-workflow-filters

Conversation

@manuzhang

Copy link
Copy Markdown
Member

Workflow-only dependency updates currently launch the general, AWS, SQL catalog, and sanitizer test suites. Scope their pull-request path filters so unrelated .github changes, such as an ASF allowlist action pin update, skip these suites.

Each suite still runs for its own workflow, shared local actions, and code/build changes; sanitizer suppression files also trigger sanitizer tests. Existing non-.github filtering and main/tag push triggers are preserved. Workflow security, allowlist, formatting, and license checks continue to run for workflow-only updates.

Validation:

  • Applicable pre-commit hooks and full online zizmor 1.30.1 audit at CI thresholds.
  • Fifteen trigger scenarios covering allowlist-only, unrelated workflow/configuration, docs, source/build/CI scripts, each suite's own workflow, shared actions, sanitizer suppressions, and mixed changes.
  • Checked all tracked paths to confirm non-.github trigger behavior is preserved; git diff --check.

The allowlist action upgrade is kept separate in #1047. This PR changes the test workflows themselves, so those suites are expected to run here to validate their changes.

Skip unrelated GitHub workflow and configuration updates in the general, AWS, SQL catalog, and sanitizer test suites. Keep each suite's own workflow and shared actions as inputs, together with sanitizer suppression files.

Co-authored-by: Codex <codex@openai.com>
Copilot AI balanced review requested due to automatic review settings October 21, 2026 14:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@manuzhang
manuzhang requested a review from wgtmac October 22, 2026 03:33

@wgtmac wgtmac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about restricting workflows such as aws, sql-catalog and hive-catalog to be triggered only when files under certain subdirectories are affected. Then use something like https://github.com/peter-evans/slash-command-dispatch to enable maintainers/reviewers to manually trigger one workflow if necessary.

@shangxinli

Copy link
Copy Markdown
Contributor

lgtm

@wgtmac
wgtmac merged commit 7ed8202 into apache:main Oct 22, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants