Skip to content

fix(store): recover channels after unavailable scans #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imbajin merged 3 commits into from
Oct 12, 2026
Merged

fix(store): recover channels after unavailable scans #3313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad0d63d
fix(store): recover channels after unavailable scans
imbajin Oct 12, 2026
baa1dc9
fix(store): retire scan pools before errors
imbajin Oct 12, 2026
6c9a272
fix(store): preserve scan failure termination
imbajin Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions ...e/hg-store-client/src/main/java/org/apache/hugegraph/store/client/grpc/KvPageScanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import org.apache.hugegraph.store.HgOwnerKey;
import org.apache.hugegraph.store.HgPageSize;
import org.apache.hugegraph.store.HgSeekAble;
import org.apache.hugegraph.store.client.HgStoreNodeManager;
import org.apache.hugegraph.store.client.HgStoreNodeSession;
import org.apache.hugegraph.store.client.util.HgBufferProxy;
import org.apache.hugegraph.store.client.util.HgStoreClientConfig;
Expand All @@ -50,6 +51,7 @@

import com.google.protobuf.ByteString;

import io.grpc.Status;
import io.grpc.stub.StreamObserver;
import lombok.extern.slf4j.Slf4j;

Expand Down Expand Up @@ -174,7 +176,7 @@ private void init() {

private void serverScan() {
if (this.completed.get()) {
this.proxy.close();
// The response callback closes the buffer after publishing its final page or error.
return;
}
if (this.proxy.isClosed()) {
Expand Down Expand Up @@ -303,7 +305,11 @@ public void onNext(KvPageRes value) {
}
if (value.getOver()) {
completed.set(true);
observer.onCompleted();
try {
observer.onCompleted();
} catch (Exception e) {
log.warn("failed to invoke requestObserver.onCompleted(), reason: {}", e.getMessage());
}
}
proxy.send(value.getDataList());
if (completed.get()) {
Expand All @@ -319,6 +325,13 @@ public void onError(Throwable t) {
} catch (Exception e) {
log.warn("failed to invoke requestObserver.onCompleted(), reason:", e.getMessage());
}
// Retire the failed pool before publishing the original iterator error,
// so immediate retries cannot reuse it. Cancellation or protocol errors
// must not evict healthy nodes, and stale notices preserve replacements.
if (Status.fromThrowable(t).getCode() == Status.Code.UNAVAILABLE) {
new NotifyingExecutor(session.getGraphName(),
HgStoreNodeManager.getInstance(), session).handleErr(t);
Comment thread
imbajin marked this conversation as resolved.
Resolved
}
proxy.setError(t);
proxy.close();
log.error("failed to complete scan of session: " + session, t);
Expand Down
2 changes: 1 addition & 1 deletion ...-store-client/src/main/java/org/apache/hugegraph/store/client/grpc/NotifyingExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ <T> Optional<T> invoke(Supplier<FeedbackRes> supplier, Function<FeedbackRes, T>
return option;
}

private void handleErr(Throwable t) {
void handleErr(Throwable t) {
try {
notifyErrConsumer(HgNodeStatus.NOT_WORK).accept(t);
} catch (Throwable tt) {
Expand Down
Loading
Loading