Repository navigation
docs: align distributed startup requirements - #517
Conversation
- describe bounded jemalloc downloads and fallback - preserve Server exit statuses and shutdown deadlines - align Store GC and Java/Maven prerequisites
- explain independent polling and diagnostic budgets - describe disabled limits and delayed exit observation - align Chinese and English deployment guidance
- scope the timeout guarantee to patched builds - document unbounded requests in earlier builds - align the Chinese and English deployment guides
- merge current documentation master - document JDK 17 build and tested runtime - align PD Maven requirements with the build
- document Server environment and Helm identity inputs - explain defaults, aliases and supported name formats - clarify graphspace creation and authentication scope
- require Java 17 in the PD startup instructions - list G1 and ZGC launcher selections - preserve caller or JVM selection when GC is omitted
- apply graphspace naming rules to environment inputs - clarify validation of the effective legacy fallback - retain the existing DEFAULT and mounted config contract
- require matching chart and Server image versions - identify the shared service identity capability - exclude unsupported earlier deployment examples
- point both Server quickstarts to the ASF repair - retain the matching chart and image requirement - connect the website update with its upstream PR
- describe literal dollar signs in Helm service IDs - document reserved legacy identity environment names - keep English and Chinese deployment guidance aligned
- document spaces and Unicode with fixed images - require intended key resupply after prior misreading - explain token renewal when the active key changes - retain replica consistency and 1.7 limitations
- describe the persisted Unicode password risk - distinguish image upgrades from credential rotation - retain signing-key and older-image boundaries
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The Docker entrypoint, partition-diagnostic, jemalloc and JDK/Maven statements match apache/hugegraph master, and the English and Chinese pages agree. Two things need changes before merge: the Server service identity section documents apache/hugegraph#3322, which is still open, and the new -g rows on the Store and PD pages describe master only while those pages install the 1.7.0 tarball, where -g g1 aborts. Evidence: read the full diff at f569d15 (8 files, +148/-22) against base 2d0b830; compared it with apache/hugegraph master 62faab73d (docker-entrypoint.sh, wait-partition.sh, start-hugegraph.sh, Store and PD launchers, Store util.sh, root pom.xml, .github/workflows/.java-version) and with tag 1.7.0; #3305, #3310, #3311, #3316 and #3327 are merged, #3322 is open; helm template of the master chart with the documented values fails schema validation; the four site build checks on this head pass (publish is skipped).
- qualify proposed Server deployment settings - explain explicit existing-graph test aliases - distinguish released and master launcher behavior - bound archive download examples
- preserve complete service IDs in metadata reads - match the case of existing Gremlin bindings - retain paired unreleased build requirements
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The launcher, JDK, GC, jemalloc, partition-diagnostic and entrypoint statements match apache/hugegraph master and tag 1.7.0, and the earlier -g thread is fixed. The Server service identity section still documents settings from apache/hugegraph#3322, which is open, and this head removed the only pointer that said so; a Minor note covers fix boundaries that lost their PR links. Evidence: read the full diff 2d0b830..957409f (8 files, +204/-30) and the delta f569d15..957409f; checked apache/hugegraph master 4b77b7bcb (start-hugegraph-pd.sh, start-hugegraph-store.sh, Store util.sh, wait-partition.sh, docker-entrypoint.sh, root pom.xml, helm/hugegraph) and tag 1.7.0; helm template of the master chart with the documented values fails schema validation; #3305, #3310, #3311, #3316 and #3327 are merged, #3322 is open; the site build checks on this head pass (publish is skipped).
imbajin
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The startup note should also say that partition polling can delay observation of Java exit before the final diagnostic. Evidence: the master entrypoint waits for the partition process before the launcher, and wait-partition.sh gives polling and diagnosis separate timeouts.
中文说明 (Chinese Summary)
背景与目标
原文档存在混杂 1.7.0 发行版说明与 master 最新启动脚本行为的问题。本 PR 系统梳理了 分布式组件启动要求、版本兼容边界与环境配置,同时补充了服务身份标识、图空间别名和认证密钥升级的最新指引。
主要改动
hugegraph-pd.md,hugegraph-hstore.md,hugegraph-server.md):-g g1;master 脚本已支持显式 G1 参数(#3305)。hugegraph-docker-cluster.md,hugegraph-server.md):server.serviceId/HG_SERVER_SERVICE_ID的命名约束(支持可打印 ASCII,字面保留$)。server.testGraphAlias说明:别名必须严格匹配本地图配置的大小写(配套 Server #3322)。hugegraph-server.md):边界与注意事项
English Description
Summary
Disentangle 1.7.0 package instructions from current-master launcher behaviors across PD, Store, and Server startup guides, while documenting service identity, graph-space bindings, and authentication upgrade fixes.
Key Changes
hugegraph-pd.md,hugegraph-hstore.md,hugegraph-server.md):-g g1/-g G1; master launchers officially support explicit G1 (#3305).hugegraph-docker-cluster.md,hugegraph-server.md):server.serviceIdrules (printable ASCII, literal handling of$without env expansion).server.testGraphAliascase-sensitive matching for local bindings (paired with Server #3322).hugegraph-server.md):Scope & Boundaries
Related Implementation PRs
Verification
dist/validate-links.sh)Implementation Overview