Repository navigation
HIVE-30131: StatsOptimizer: Answer MIN, MAX and COUNT on a DECIMAL column from column statistics - #6844
Open
deniskuzZ wants to merge 1 commit into
Open
HIVE-30131: StatsOptimizer: Answer MIN, MAX and COUNT on a DECIMAL column from column statistics#6844deniskuzZ wants to merge 1 commit into
deniskuzZ wants to merge 1 commit into
Conversation
asf-ci-hive
added
tests pending
tests failed
and removed
tests pending
tests failed
labels
deniskuzZ
changed the title
deniskuzZ
force-pushed
the
HIVE-30131
branch
2 times, most recently
from
October 5, 2026 22:55
c24a193 to
ba8a463
Compare
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
…lumn from column statistics - getType mapped a decimal column to StatType.Unsupported, so min, max and count(col) over one scanned the table even with accurate satistics - add StatType.Decimal and the cases its exhaustive switches then require - read the bound through DecimalUtils.getHiveDecimal, as the metastore does - partitioned tables need no fold here: statsFor already aggregates them
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation handles DECIMAL bounds and null counts consistently and includes broad regression coverage.
0 open findings
What changed in this PR
Adds statistics-based optimization for MIN, MAX, and COUNT on DECIMAL columns.
Changes:
- Maps DECIMAL types to decimal column statistics and converts stored bounds to
HiveDecimal. - Tests native, partitioned, all-NULL, and Iceberg decimal columns.
- Disables stats optimization in the vectorized UDF execution test.
| File | Description |
|---|---|
ql/src/java/.../StatsOptimizer.java |
Implements DECIMAL statistics support. |
ql/src/test/queries/clientpositive/metadata_only_queries.q |
Adds native-table DECIMAL tests. |
ql/src/test/results/clientpositive/llap/metadata_only_queries.q.out |
Records native-table results and plans. |
ql/src/test/queries/clientpositive/vector_decimal_udf.q |
Preserves vectorized execution coverage. |
iceberg/.../iceberg_part_colstats.q |
Adds Iceberg DECIMAL statistics tests. |
iceberg/.../iceberg_part_colstats.q.out |
Records Iceberg results and plans. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| set hive.explain.user=false; | ||
| SET hive.vectorized.execution.enabled=true; | ||
| set hive.fetch.task.conversion=minimal; | ||
| set hive.compute.query.using.stats=false; |
Contributor
There was a problem hiding this comment.
Based on CI run 7 I'm assuming, this was explicitly turned off to preserve the vectorized Tez execution coverage and new q file (metadata_only_queries.q and iceberg_part_colstats.q.) will test this PR?
Member
Author
There was a problem hiding this comment.
yes, exactly. Otherwise, vector_decimal_udf.q was answered from stats, skipping execution
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Missing stats optimization for DECIMAL column
Does this PR introduce any user-facing change?
No
How was this patch tested?
metadata_only_queries.q