[hotfix][server] Simplify KV cleanup tests and directory discovery - #4414
Open
swuferhong wants to merge 1 commit into
Open
swuferhong wants to merge 1 commit into
swuferhong wants to merge 1 commit into
Conversation
Consolidate overlapping KV cleanup tests while retaining controlled shutdown, snapshot recovery, and failed-deletion isolation coverage. Use shared directory discovery for logs and KV. Skip symbolic links without following their targets and continue past unreadable directories. Validation: 55 targeted tests passed. Both tablet discovery cases passed again after the final NOFOLLOW_LINKS simplification. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-6 AI-Contributed/Feature: 90/90 AI-Contributed/UT: 274/274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Follow up on #4401 by consolidating overlapping cleanup tests while retaining coverage for controlled shutdown, snapshot and log recovery, and failed-deletion isolation.
Share directory discovery between LogManager and KvManager, skip symbolic links without following their targets, and continue scanning sibling directories when one directory cannot be listed.
Brief change log
Tests
API and Format
Documentation