Conversation
There is an old optimization in StringUtils#fromUtf8 and toUtf8 that has outlived its usefulness. Apparently it used to be faster to pass the String charset name rather than a Charset object, but that is no longer the case.
Contributor
Author
|
Benchmarks. Not checked in, they're just doing the two alternatives on various lengths of strings. |
FrankChen021
left a comment
Member
There was a problem hiding this comment.
🟢 Approval recommended
No actionable issues found in this review. The production change keeps the UTF-8 conversion behavior while using StandardCharsets.UTF_8 directly, and the repository-wide references, surrounding call sites, compatibility guidance, and all changed tests were inspected.
Reviewed 6 of 6 changed files.
This is an automated review by Codex GPT-5.6-Luna(max)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an old optimization in StringUtils#fromUtf8 and toUtf8 that has outlived its usefulness. Apparently it used to be faster to pass the String charset name rather than a Charset object, but that is no longer the case.