Repository navigation
[MINOR UPDATE]: Potential fix for code scanning alert no. 41: Use of a cryptographic algorithm with insufficient key size - #3089
Merged
Conversation
…algorithm with insufficient key size Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
cgivre
changed the title
cgivre
marked this pull request as ready for review
October 2, 2026 19:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/apache/drill/security/code-scanning/41
The correct fix is to increase the RSA key size used during key-pair generation from 1024 to 2048 bits (or higher). This preserves existing behavior (auto-generating a self-signed certificate for the web server) while making the generated key compliant with current minimum recommendations.
In
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/ssl/SslContextFactoryConfigurator.java, update theuseAutoGeneratedSelfSignedCertificate(...)method at the key generation block:RSA.keyPairGenerator.initialize(1024, random);withkeyPairGenerator.initialize(2048, random);.No additional imports, methods, or dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.