[LucaCappelletti94]

SQLite and DuckDB accept an aggregate call whose only content is an ORDER BY clause, such as SELECT count(ORDER BY a) FROM t, but the parser failed with Expected: ), found: BY. SQLite documents ORDER BY inside aggregate calls (https://www.sqlite.org/lang_aggfunc.html#aggorderby) and so does DuckDB (https://duckdb.org/docs/current/sql/functions/aggregates#order-by-clause-in-aggregate-functions). SQLite 3.51.1 and DuckDB 1.4.4 both run count(ORDER BY a) and count(ORDER BY a ASC, b DESC) and both reject count(DISTINCT ORDER BY a). SQLite also accepts count(ALL ORDER BY a).

A new dialect method, supports_aggregate_order_by_with_empty_args, enables the form for SQLite, DuckDB and the generic dialect. DISTINCT still requires an argument. Tests now cover every dialect on both sides of the capability.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.84%. Comparing base (6a8b8bb) to head (1612cae).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2660   +/-   ##
=======================================
  Coverage   81.83%   81.84%           
=======================================
  Files          42       42           
  Lines       34651    34667   +16     
  Branches    34651    34667   +16     
=======================================
+ Hits        28357    28373   +16     
  Misses       2753     2753           
  Partials     3541     3541           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[alamb]

I bet if you changed these PRs so they didn't all try and put the tests at the end of this file (put it after different other tsts) they wouldn't all conflict

[LucaCappelletti94]

I tried to scramble them, and it seems to have made some but little difference.