[mvisani]

The tokenizer never treated a backslash as an escape inside a quoted identifier, but EscapeQuotedString assumed a quote after a backslash was already escaped. The rendered SQL was then unterminated, e.g. SELECT "a\""" displayed as SELECT "a\"" and failed to re-parse. Found by fuzzing fuzz_parse_roundtrip.

[github-actions]

No dialect label was applied because the title does not name a SQL dialect.

If this change targets one or more dialects, edit the title to <Dialect>[, <Dialect>]: <description>, add a Dialects: <Dialect>[, <Dialect>] line to the description, or reply with one. Reply Dialects: none if the change is dialect-agnostic.

[LucaCappelletti94]

@mvisani add to the fuzzer seed corpus the crashing case, so it will be faster to get to next time around

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.10%. Comparing base (5cad906) to head (a0324d4).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2593   +/-   ##
=======================================
  Coverage   81.09%   81.10%           
=======================================
  Files          42       42           
  Lines       33684    33695   +11     
  Branches    33684    33695   +11     
=======================================
+ Hits        27316    27327   +11     
  Misses       2798     2798           
  Partials     3570     3570           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[LucaCappelletti94]

FYI, the fuzzer crash is not caused by your code, just the seed you added facilitated the fuzzer in finding it. Can you please rebase the PR?

[mvisani]

@LucaCappelletti94 Should be done !