Driver is called when nothing is changed in volume resize wizard by sathvikaragi · Pull Request #14259 · apache/cloudstack

sathvikaragi · 2026-09-29T06:22:02Z

Description

Calling resizeVolume with the existing volume details and not changing anything in wizard still invoked the storage driver, causing an unnecessary driver resize request for volumes.

fixes : #14260

This PR...

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

actually resizes (In backend driver call is made and in UI also we can see it is resizing)

Shows success immediately:

when diskoffering ID is same as what volume already has driver is not called and it is returned immediately :

How Has This Been Tested?

How did you try to break this feature and the system with this change?

#110) Calling resizeVolume with the existing volume size still invoked the storage driver, causing an unnecessary driver resize request for volumes. ### Description This PR...           ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [X] Minor - [ ] Trivial ### Screenshots (if appropriate): Before Patch API is still called in case of no changes in the wizard: <img width="1423" height="1034" alt="Screenshot 2026-09-24 at 4 33 33 PM" src="https://github.com/user-attachments/assets/5480986e-bc79-4bc7-b05c-62077c2cc93e" /> actually resizes (IN UI) <img width="1441" height="638" alt="Screenshot 2026-09-24 at 4 36 00 PM" src="https://github.com/user-attachments/assets/8430eaa3-947e-41d4-8573-518f7831d7f0" /> after the fix Patch api is not called : <img width="1393" height="1035" alt="Screenshot 2026-09-24 at 4 17 52 PM" src="https://github.com/user-attachments/assets/b53e1146-560a-437a-9b0c-501be9ec4d76" /> Shows success immediately: <img width="1471" height="728" alt="Screenshot 2026-09-24 at 4 28 37 PM" src="https://github.com/user-attachments/assets/9cdd57b0-2b1f-4550-9830-46f87c439061" /> ### How Has This Been Tested?   #### How did you try to break this feature and the system with this change?

sathvikaragi · 2026-10-01T06:42:39Z

@weizhouapache @DaanHoogland @nvazquez

DaanHoogland

clgtm

codecov · 2026-10-02T08:06:17Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.91%. Comparing base (510d0ec) to head (762a4c9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	0.00%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #14259   +/-   ##
=========================================
  Coverage     19.91%   19.91%           
- Complexity    20194    20197    +3     
=========================================
  Files          6373     6373           
  Lines        577230   577231    +1     
  Branches      70696    70697    +1     
=========================================
+ Hits         114942   114958   +16     
+ Misses       449722   449707   -15     
  Partials      12566    12566

Flag	Coverage Δ
uitests	`3.71% <ø> (ø)`
unittests	`21.18% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

2 open findings

volume is reloaded before updating the disk offering, so the returned volume (and the… · New
This forces an extra DB fetch even when newDiskOffering == null and you’re returning early… · New

What changed in this PR

Prevents invoking the storage driver (and related backend resize flow) when the volume resize wizard is submitted without any actual changes, addressing #14260.

Changes:

Expands the early-return path to trigger when neither migration nor resize is required, even if no new disk offering is provided.
Guards disk-offering updates so they only run when newDiskOffering != null.

File	Description
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java	Adjusts the “no-op resize” logic to return early without calling the storage driver unless a disk offering change is explicitly requested.

🧠 Review effort: Lite

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

sathvikaragi · 2026-10-13T10:52:46Z

+            if (!volumeMigrateRequired && !volumeResizeRequired) {
                volume = _volsDao.findById(volume.getId());
-                updateStorageWithTheNewDiskOffering(volume, newDiskOffering);
-
+                if (newDiskOffering != null) {
+                    _volsDao.updateDiskOffering(volume.getId(), newDiskOffering.getId());
+                    updateStorageWithTheNewDiskOffering(volume, newDiskOffering);
+                }
                return volume;
            }


Volume is now reloaded after _volsDao.updateDiskOffering, hence this issue won't be faced.

sathvikaragi · 2026-10-13T10:53:56Z

-            if (!volumeMigrateRequired && !volumeResizeRequired && newDiskOffering != null) {
-                _volsDao.updateDiskOffering(volume.getId(), newDiskOffering.getId());
+            if (!volumeMigrateRequired && !volumeResizeRequired) {
                volume = _volsDao.findById(volume.getId());


volume is now fetched here only after the DB update to pass on to updateStorageWithTheNewDiskOffering(volume, newDiskOffering);

Damans227 · 2026-10-09T15:33:13Z

                volume = _volsDao.findById(volume.getId());
-                updateStorageWithTheNewDiskOffering(volume, newDiskOffering);
-
+                if (newDiskOffering != null) {


should we also skip this when the new offering is the same as the current one? nothing changes then but the storage driver still gets called here

I agree, I have added that check to compare newdiskofferingID and volume's diskoffering ID. Now when same ID is given driver call is skipped and volume is returned.

#120) … volume resize return early ### Description This PR...           ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [X] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [X] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? In case a newerdiskofferingID is mentioned in API then it updates the DB. <img width="1394" height="814" alt="Screenshot 2026-10-13 at 11 53 33 AM" src="https://github.com/user-attachments/assets/9b4e8249-c639-4d29-8ca4-9431b4f1b6cd" /> when same ID is given then it immediately returns. <img width="1404" height="522" alt="Screenshot 2026-10-13 at 11 53 44 AM" src="https://github.com/user-attachments/assets/d6d0350c-464b-4644-9470-b8879ebdb48c" />   #### How did you try to break this feature and the system with this change?

Damans227

thanks @sathvikaragi, the same offering check looks right. LGTM

boring-cyborg Bot added the component:storage label Sep 29, 2026

sathvikaragi changed the title ~~when nothing is changed in volume resize wizard directl…~~ Driver is called when nothing is changed in volume resize wizard Sep 29, 2026

sathvikaragi marked this pull request as ready for review September 29, 2026 06:29

DaanHoogland approved these changes Oct 2, 2026

View reviewed changes

nvazquez added this to the 24.0 milestone Oct 8, 2026

nvazquez requested a balanced review from Copilot October 8, 2026 11:01

Copilot AI reviewed Oct 8, 2026

View reviewed changes

Copilot stopped reviewing on behalf of nvazquez due to an error October 8, 2026 11:34
An unexpected error occurred. For more details, see the detailed logs in GitHub Actions.

Damans227 reviewed Oct 9, 2026

View reviewed changes

Damans227 approved these changes Oct 13, 2026

View reviewed changes

Navigation Menu

Repository navigation

Driver is called when nothing is changed in volume resize wizard - #14259

Driver is called when nothing is changed in volume resize wizard#14259
sathvikaragi wants to merge 2 commits into
apache:mainfrom
NetApp:handle-volume-resize-no-changes

sathvikaragi commented Sep 29, 2026 •

edited

Loading

Uh oh!

sathvikaragi commented Oct 1, 2026

Uh oh!

DaanHoogland left a comment

Uh oh!

codecov Bot commented Oct 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

sathvikaragi Oct 13, 2026

Uh oh!

sathvikaragi Oct 13, 2026

Uh oh!

Damans227 Oct 9, 2026

Uh oh!

sathvikaragi Oct 13, 2026

Uh oh!

Damans227 left a comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

sathvikaragi commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sathvikaragi commented Oct 1, 2026

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

Uh oh!

sathvikaragi Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

sathvikaragi Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

Damans227 Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

sathvikaragi Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

Damans227 left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sathvikaragi commented Sep 29, 2026 •

edited

Loading

codecov Bot commented Oct 2, 2026 •

edited

Loading