Skip to content

KVM: Support multi vlan trunk NICs - #14166

Draft
Pearl1594 wants to merge 29 commits into
mainfrom
support-multi-vlan-guestnet
Draft

KVM: Support multi vlan trunk NICs#14166
Pearl1594 wants to merge 29 commits into
mainfrom
support-multi-vlan-guestnet

Increase test coverage

a0f47df
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 13, 2026 in 5m 41s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 1438 in server/src/main/java/com/cloud/network/router/CommandSetupHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "networkId" private field. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYAz9ApHmdrJ_o8Khh&open=AaEYAz9ApHmdrJ_o8Khh&pullRequest=14166

Check warning on line 488 in server/src/test/java/com/cloud/deploy/DeploymentPlanningManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0qnpHmdrJ_o8KpN&open=AaEYA0qnpHmdrJ_o8KpN&pullRequest=14166

Check warning on line 1654 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8Kj0&open=AaEYA0ZhpHmdrJ_o8Kj0&pullRequest=14166

Check warning on line 1468 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8KiX&open=AaEYA0ZhpHmdrJ_o8KiX&pullRequest=14166

Check warning on line 1680 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8KkE&open=AaEYA0ZhpHmdrJ_o8KkE&pullRequest=14166

Check warning on line 1854 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8KlG&open=AaEYA0ZipHmdrJ_o8KlG&pullRequest=14166

Check warning on line 1722 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8KkU&open=AaEYA0ZhpHmdrJ_o8KkU&pullRequest=14166

Check warning on line 2320 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8KoE&open=AaEYA0ZipHmdrJ_o8KoE&pullRequest=14166

Check warning on line 138 in server/src/test/java/com/cloud/network/router/CommandSetupHelperTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0awpHmdrJ_o8KoM&open=AaEYA0awpHmdrJ_o8KoM&pullRequest=14166

Check warning on line 267 in server/src/test/java/org/apache/cloudstack/storage/template/VnfTemplateManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0X1pHmdrJ_o8KiF&open=AaEYA0X1pHmdrJ_o8KiF&pullRequest=14166

Check warning on line 2222 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8Kna&open=AaEYA0ZipHmdrJ_o8Kna&pullRequest=14166

Check warning on line 1709 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8KkQ&open=AaEYA0ZhpHmdrJ_o8KkQ&pullRequest=14166

Check warning on line 1569 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8KjA&open=AaEYA0ZhpHmdrJ_o8KjA&pullRequest=14166

Check warning on line 1518 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the body of this try/catch to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8Kiq&open=AaEYA0ZhpHmdrJ_o8Kiq&pullRequest=14166

Check warning on line 154 in server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYAzuApHmdrJ_o8KhQ&open=AaEYAzuApHmdrJ_o8KhQ&pullRequest=14166

Check warning on line 187 in server/src/test/java/com/cloud/network/router/CommandSetupHelperTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0awpHmdrJ_o8KoT&open=AaEYA0awpHmdrJ_o8KoT&pullRequest=14166

Check warning on line 1694 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8KkL&open=AaEYA0ZhpHmdrJ_o8KkL&pullRequest=14166

Check warning on line 1650 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8Kjv&open=AaEYA0ZhpHmdrJ_o8Kjv&pullRequest=14166

Check warning on line 1619 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_nativeVlanTag" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYAzlipHmdrJ_o8KhJ&open=AaEYAzlipHmdrJ_o8KhJ&pullRequest=14166

Check warning on line 2226 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8Knd&open=AaEYA0ZipHmdrJ_o8Knd&pullRequest=14166

Check warning on line 2066 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8KmL&open=AaEYA0ZipHmdrJ_o8KmL&pullRequest=14166

Check warning on line 150 in engine/components-api/src/main/java/com/cloud/event/UsageEventUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 10 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYAy7spHmdrJ_o8Kgk&open=AaEYAy7spHmdrJ_o8Kgk&pullRequest=14166

Check warning on line 1408 in engine/orchestration/src/test/java/com/cloud/vm/VirtualMachineManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "times". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYAy4ApHmdrJ_o8Kgd&open=AaEYAy4ApHmdrJ_o8Kgd&pullRequest=14166

Check warning on line 2102 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8KmW&open=AaEYA0ZipHmdrJ_o8KmW&pullRequest=14166

Check warning on line 672 in server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0kvpHmdrJ_o8Ko1&open=AaEYA0kvpHmdrJ_o8Ko1&pullRequest=14166
View more details on SonarQubeCloud