Repository navigation
Add performance indexes - #13856
Add performance indexes#13856sb-abhish3k wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13856 +/- ##
============================================
- Coverage 18.00% 18.00% -0.01%
+ Complexity 16219 16215 -4
============================================
Files 5936 5936
Lines 535716 535716
Branches 65596 65596
============================================
- Hits 96459 96432 -27
- Misses 428268 428295 +27
Partials 10989 10989
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@blueorangutan package |
|
@sb-abhish3k a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18968 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-16850) |
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19038 |
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, but I think we are about to release 23, so the calls will need to be moved soon/before merging
bdf94b2 to
29e2f0f
Compare
|
Rebased to target 4.22 branch |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19334 |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@blueorangutan test |
|
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-17081)
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
| -- (WHERE archived = 0 AND level = ? ORDER BY created) | ||
| CALL `cloud`.`IDEMPOTENT_ADD_INDEX`('i_event__archived_level_created', 'cloud.event', '(archived, level, created)'); | ||
| -- event table: default listEvents path (account + archived + sort) | ||
| CALL `cloud`.`IDEMPOTENT_ADD_INDEX`('i_event__account_archived_created', 'cloud.event', '(account_id, archived, created DESC)'); |
There was a problem hiding this comment.
should we drop the old account id and archived indexes on the event table? the new ones cover them and this table gets a write on almost every action
There was a problem hiding this comment.
It can be done in a separate PR
|
|
||
| -- Idempotent ADD INDEX | ||
| DROP PROCEDURE IF EXISTS `cloud`.`IDEMPOTENT_ADD_INDEX`; | ||
| CREATE PROCEDURE `cloud`.`IDEMPOTENT_ADD_INDEX` ( |
There was a problem hiding this comment.
can we reuse the existing IDEMPOTENT_ADD_KEY here? looks like the only difference is the online lock option
There was a problem hiding this comment.
If no major objection, we can proceed with the current procedure
Damans227
left a comment
Damans227
left a comment
There was a problem hiding this comment.
@sb-abhish3k fine to do the cleanup in a separate PR. LGTM.
This branch has not been deployed
9 participants
Description
Adds performance indexes for common DB lookups.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?