Repository navigation
Remove awsapi leftovers - #13712
Open
winterhazel wants to merge 2 commits into
Open
Remove awsapi leftovers#13712winterhazel wants to merge 2 commits into
winterhazel wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13712 +/- ##
=========================================
Coverage 19.65% 19.65%
+ Complexity 19792 19790 -2
=========================================
Files 6368 6367 -1
Lines 574881 574807 -74
Branches 70351 70345 -6
=========================================
- Hits 112970 112957 -13
+ Misses 449639 449578 -61
Partials 12272 12272
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Damans227
reviewed
Oct 14, 2026
| -- Schema upgrade from 4.23.0.0 to 4.24.0.0 | ||
| --; | ||
|
|
||
| -- Remove leftovers from awsapi |
Collaborator
There was a problem hiding this comment.
does anything run this script yet? i dont see a 4.23 to 4.24 upgrade step on main, so should these lines go in the 4.22.1 to 4.23 script instead?
Damans227
reviewed
Oct 14, 2026
| @Param(description = "Path of the Domain the Account belongs to", since = "4.13") | ||
| private String domainPath; | ||
|
|
||
| @SerializedName(ApiConstants.DEFAULT_ZONE_ID) |
Collaborator
There was a problem hiding this comment.
should we tick breaking change here? anyone calling the mark default zone api or reading the default zone from list accounts will break after upgrade
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a few leftovers from awsapi.
Column
default_zone_idwas added toaccountsolely for the integration, and is not used anymore. APImarkDefaultZoneForAccountwas created to set the value of this unused column.Types of changes
How Has This Been Tested?
Tests are still pending.