Skip to content

Prevent downloading templates to secondary storages that are in read-only #13023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GaOrtiga wants to merge 8 commits into
base: 4.20
Choose a base branch
from
Open

Prevent downloading templates to secondary storages that are in read-only #13023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0d2f3d6
dont download templates to read-only storages
GaOrtiga Apr 14, 2026
c6ff0f2
fix_typos
GaOrtiga Apr 15, 2026
d46b59e
fix tests
GaOrtiga Apr 20, 2026
939e488
address sureshanaparti's review
GaOrtiga May 8, 2026
0e46501
fix tests
GaOrtiga May 22, 2026
0ddd00f
address fabricios review + address heuristics
GaOrtiga Jun 5, 2026
40e82c2
address_copilot
GaOrtiga Aug 5, 2026
b1905ef
remove unnecessary stubbings
GaOrtiga Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...pi/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,6 @@ public interface DataStoreManager {
DataStore getImageStoreByUuid(String uuid);

Long getStoreZoneId(long storeId, DataStoreRole role);

boolean isRemovedOrReadonly(DataStore store);
}
9 changes: 8 additions & 1 deletion .../storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
import org.apache.cloudstack.storage.command.DeleteCommand;
import org.apache.cloudstack.storage.datastore.DataObjectManager;
import org.apache.cloudstack.storage.datastore.ObjectInDataStoreManager;
import org.apache.cloudstack.storage.datastore.db.ImageStoreDao;
import org.apache.cloudstack.storage.datastore.db.TemplateDataStoreDao;
import org.apache.cloudstack.storage.datastore.db.TemplateDataStoreVO;
import org.apache.cloudstack.storage.image.datastore.ImageStoreEntity;
Expand Down Expand Up @@ -163,6 +164,8 @@ public class TemplateServiceImpl implements TemplateService {
TemplateDataFactory imageFactory;
@Inject
StorageOrchestrationService storageOrchestrator;
@Inject
ImageStoreDao imageStoreDao;

class TemplateOpContext<T> extends AsyncRpcContext<T> {
final TemplateObject template;
Expand Down Expand Up @@ -295,10 +298,14 @@ public void handleSysTemplateDownload(HypervisorType hostHyper, Long dcId) {
}

protected boolean shouldDownloadTemplateToStore(VMTemplateVO template, DataStore store) {
if (_storeMgr.isRemovedOrReadonly(store)) {
return false;
Comment thread
GaOrtiga marked this conversation as resolved.
}
Comment thread
GaOrtiga marked this conversation as resolved.

Long zoneId = store.getScope().getScopeId();
DataStore directedStore = _tmpltMgr.verifyHeuristicRulesForZone(template, zoneId);

@Damans227 Damans227 Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens to the template sync when the rule points at a read-only store? looks like this now throws mid loop and the rest of the templates for that store get skipped

if (directedStore != null && store.getId() != directedStore.getId()) {
logger.info("Template [{}] will not be download to image store [{}], as a heuristic rule is directing it to another store.",
logger.info("Template [{}] will not be downloaded to image store [{}], as a heuristic rule is directing it to another store.",
template.getUniqueName(), store.getName());
return false;
}
Expand Down
15 changes: 15 additions & 0 deletions ...rage/image/src/test/java/org/apache/cloudstack/storage/image/TemplateServiceImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
import org.apache.cloudstack.engine.subsystem.api.storage.DataStore;
import org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager;
import org.apache.cloudstack.engine.subsystem.api.storage.Scope;
import org.apache.cloudstack.storage.datastore.db.ImageStoreDao;
import org.apache.cloudstack.storage.datastore.db.ImageStoreVO;
import org.apache.cloudstack.storage.datastore.db.TemplateDataStoreDao;
import org.apache.cloudstack.storage.datastore.db.TemplateDataStoreVO;
import org.apache.cloudstack.storage.image.store.TemplateObject;
Expand Down Expand Up @@ -104,6 +106,12 @@ public class TemplateServiceImplTest {
@Mock
DataCenterDao _dcDao;

@Mock
ImageStoreDao imageStoreDao;

@Mock
ImageStoreVO imageStoreMock;

Comment thread
GaOrtiga marked this conversation as resolved.
Map<String, TemplateProp> templatesInSourceStore = new HashMap<>();

@Before
Expand Down Expand Up @@ -158,6 +166,13 @@ public void shouldDownloadTemplateToStoreTestSkipsPrivateExistingTemplate() {
Assert.assertFalse(templateService.shouldDownloadTemplateToStore(tmpltMock, dataStoreMock));
}

@Test
public void shouldDownloadTemplateToStoreTestSkipsWhenStorageIsReadOnly() {
Mockito.when(dataStoreManagerMock.isRemovedOrReadonly(Mockito.any())).thenReturn(true);
Assert.assertFalse(templateService.shouldDownloadTemplateToStore(tmpltMock, dataStoreMock));

}

@Test
public void tryDownloadingTemplateToImageStoreTestDownloadsTemplateWhenUrlIsNotNull() {
Mockito.doReturn("url").when(tmpltMock).getUrl();
Expand Down
22 changes: 22 additions & 0 deletions ...e/storage/src/main/java/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@
import org.apache.cloudstack.engine.subsystem.api.storage.DataStore;
import org.apache.cloudstack.engine.subsystem.api.storage.ZoneScope;
import org.apache.cloudstack.engine.subsystem.api.storage.Scope;
import org.apache.cloudstack.storage.datastore.db.ImageStoreDao;
import org.apache.cloudstack.storage.datastore.db.ImageStoreVO;
import org.apache.cloudstack.storage.object.datastore.ObjectStoreProviderManager;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.springframework.stereotype.Component;

import org.apache.cloudstack.storage.image.datastore.ImageStoreProviderManager;
Expand All @@ -37,12 +41,16 @@

@Component
public class DataStoreManagerImpl implements DataStoreManager {
protected Logger logger = LogManager.getLogger(DataStoreManagerImpl.class);

@Inject
PrimaryDataStoreProviderManager primaryStoreMgr;
@Inject
ImageStoreProviderManager imageDataStoreMgr;
@Inject
ObjectStoreProviderManager objectStoreProviderMgr;
@Inject
ImageStoreDao imageStoreDao;

@Override
public DataStore getDataStore(long storeId, DataStoreRole role) {
Expand Down Expand Up @@ -199,4 +207,18 @@ public Long getStoreZoneId(long storeId, DataStoreRole role) {
} catch (CloudRuntimeException ignored) {}
return null;
}

@Override
public boolean isRemovedOrReadonly(DataStore store) {
ImageStoreVO storeVO = imageStoreDao.findById(store.getId());
if (storeVO == null) {
logger.debug("Could not find image store with id [{}], skipping it.", store.getId());
return true;
}
if (storeVO.isReadonly()) {
logger.debug("Image store [{}] is read-only, skipping it.", storeVO);
return true;
}
return false;
}
Comment thread
GaOrtiga marked this conversation as resolved.
}
5 changes: 5 additions & 0 deletions server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,11 @@ protected boolean isZoneAndImageStoreAvailable(DataStore imageStore, Long zoneId
return false;
}

if (storeMgr.isRemovedOrReadonly(imageStore)) {
logger.info("Image store [{}] is marked as read-only. Skip downloading template to this image store.", imageStore);
return false;
}
Comment thread
GaOrtiga marked this conversation as resolved.

if (!_statsCollector.imageStoreHasEnoughCapacity(imageStore)) {
logger.info("Image store doesn't have enough capacity. Skip downloading template to this image store [{}].", imageStore);
return false;
Expand Down
4 changes: 4 additions & 0 deletions server/src/main/java/org/apache/cloudstack/storage/heuristics/HeuristicRuleHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,10 @@ public DataStore interpretHeuristicRule(String rule, HeuristicType heuristicType
"returning a valid UUID.", scriptReturn, rule));
}

if (dataStoreManager.isRemovedOrReadonly(dataStore)) {
throw new CloudRuntimeException(String.format("DataStore [{}] returned by heuristic rule is marked as read-only.", dataStore));

@Damans227 Damans227 Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be %s instead of {}? String.format leaves the {} as is so the store never shows up in the error

}

return dataStore;
} catch (IOException ex) {
String message = String.format("Error while executing script [%s].", rule);
Expand Down
9 changes: 9 additions & 0 deletions server/src/test/java/com/cloud/template/HypervisorTemplateAdapterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@
import org.apache.cloudstack.framework.events.Event;
import org.apache.cloudstack.framework.events.EventDistributor;
import org.apache.cloudstack.framework.messagebus.MessageBus;
import org.apache.cloudstack.storage.datastore.db.ImageStoreDao;
import org.apache.cloudstack.storage.datastore.db.ImageStoreVO;
import org.apache.cloudstack.storage.datastore.db.TemplateDataStoreDao;
import org.apache.cloudstack.storage.datastore.db.TemplateDataStoreVO;
import org.apache.cloudstack.storage.heuristics.HeuristicRuleHelper;
Expand Down Expand Up @@ -137,6 +139,9 @@ public class HypervisorTemplateAdapterTest {
@Mock
StatsCollector statsCollectorMock;

@Mock
ImageStoreDao _imgStoreDao;

@Mock
Logger loggerMock;

Expand Down Expand Up @@ -458,6 +463,7 @@ public void isZoneAndImageStoreAvailableTestZoneIsDisabledShouldReturnFalse() {
@Test
public void isZoneAndImageStoreAvailableTestImageStoreDoesNotHaveEnoughCapacityShouldReturnFalse() {
DataStore dataStoreMock = Mockito.mock(DataStore.class);
ImageStoreVO ImageStoreVOMock = Mockito.mock(ImageStoreVO.class);
Long zoneId = 1L;
Set<Long> zoneSet = null;
boolean isTemplatePrivate = false;
Expand All @@ -477,6 +483,7 @@ public void isZoneAndImageStoreAvailableTestImageStoreDoesNotHaveEnoughCapacityS
@Test
public void isZoneAndImageStoreAvailableTestImageStoreHasEnoughCapacityAndZoneSetIsNullShouldReturnTrue() {
DataStore dataStoreMock = Mockito.mock(DataStore.class);
ImageStoreVO ImageStoreVOMock = Mockito.mock(ImageStoreVO.class);
Long zoneId = 1L;
Set<Long> zoneSet = null;
boolean isTemplatePrivate = false;
Expand All @@ -496,6 +503,7 @@ public void isZoneAndImageStoreAvailableTestImageStoreHasEnoughCapacityAndZoneSe
@Test
public void isZoneAndImageStoreAvailableTestTemplateIsPrivateAndItIsAlreadyAllocatedToTheSameZoneShouldReturnFalse() {
DataStore dataStoreMock = Mockito.mock(DataStore.class);
ImageStoreVO ImageStoreVOMock = Mockito.mock(ImageStoreVO.class);
Long zoneId = 1L;
Set<Long> zoneSet = Set.of(1L);
boolean isTemplatePrivate = true;
Expand All @@ -515,6 +523,7 @@ public void isZoneAndImageStoreAvailableTestTemplateIsPrivateAndItIsAlreadyAlloc
@Test
public void isZoneAndImageStoreAvailableTestTemplateIsPrivateAndItIsNotAlreadyAllocatedToTheSameZoneShouldReturnTrue() {
DataStore dataStoreMock = Mockito.mock(DataStore.class);
ImageStoreVO imageStoreVoMock = Mockito.mock(ImageStoreVO.class);
Long zoneId = 1L;
Set<Long> zoneSet = new HashSet<>();
boolean isTemplatePrivate = true;
Expand Down
Loading