Skip to content

Role changes after selecting domain in create account form #13191

Closed

Description

@gp-santos

Hi, #12200 added a QoL change to pre-assign the domain according to URL path and it then changes the default role to match said domain.

However, I feel it worsens the default experience when you fill the form from top to bottom: when creating a user, it changes the role to the default one even after specifically selecting before.

Filling out form:

Image

And after changing the domain:

Image

I ended up creating test accounts with different roles then I had intended and I fear this would cause misunderstandings in main. What do you think, @Pearl1594, @DaanHoogland , @weizhouapache ?

Activity

  1. kiranchavala commented on May 20, 2026

    @kiranchavala
    Member

    Thanks @gp-santos I too faced this issue many times, We shouldn't reload the account creation form when domain is changed

    I beleive its a valid improvement request

  2. added this to the 4.24.0 milestone on May 20, 2026
  3. Pearl1594 commented on May 21, 2026

    @Pearl1594
    Contributor

    Fair Point @gp-santos - maybe if the role is Higher (say, Admin) than what the domain (ROOT/a) can accept, then we can make the change as before, else leave the user filled Role.

  4. gp-santos commented on May 21, 2026

    @gp-santos
    CollaboratorAuthor

    Seems good to me, @Pearl1594

    However, I feel this should be on 4.23, would it be alright, @DaanHoogland, @winterhazel, @weizhouapache ?

    Also, would you rather do it or may I assign this to myself, @Pearl1594 ?

  5. winterhazel commented on May 21, 2026

    @winterhazel
    Member

    @gp-santos I agree that it is better to address this in 4.23 already, so I'm changing the milestone.

  6. modified the milestones: 4.24.0, 4.23.0 on May 21, 2026
  7. Pearl1594 commented on May 21, 2026

    @Pearl1594
    Contributor

    I agree - it would be better to go into 4.23 - and if you want to work on the fix you can go ahead @gp-santos , no problem. I can help review.

  8. self-assigned this
    on May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions