Repository navigation
Conversation
Compiled with the server's warning flags, two unit test sources warn: ginpostinglist_fakes.c:67: warning: control reaches end of non-void function [-Wreturn-type] dfmgr_test.c:68: warning: function 'errdetail_internal_impl' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] The pg_fprintf() fake is declared to return int and returned nothing; it returns 0 now. errdetail_internal_impl(), which stands in for errdetail() and errdetail_internal(), now carries their printf attribute, so its callers in dfmgr.c are format-checked as they are against the real functions, and it calls va_end(), which it never did. `make unittest-check` compiles the tests with CFLAGS=-DUNITTEST alone, which is why it does not show these. Assisted-by: Claude Code
1 of 13 tasks
leborchuk
approved these changes
Oct 26, 2026
leborchuk
left a comment
leborchuk
left a comment
Contributor
There was a problem hiding this comment.
LGTM, fix warning, it's just warnings, they mean nothing really important, mostly the results are ignored
Alena0704
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiled with the server's warning flags, two unit test sources warn:
The pg_fprintf() fake is declared to return int and returned nothing; it returns 0 now. errdetail_internal_impl(), which stands in for errdetail() and errdetail_internal(), now carries their printf attribute, so its callers in dfmgr.c are format-checked as they are against the real functions, and it calls va_end(), which it never did.
make unittest-checkcompiles the tests with CFLAGS=-DUNITTEST alone, which is why it does not show these.Assisted-by: Claude Code
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions