Repository navigation
Conversation
Every object of the backend unit tests is compiled with
-DDLSUFFIX=.so, and pg_config.h then defines DLSUFFIX as ".so":
pg_config.h:47:9: warning: 'DLSUFFIX' redefined
47 | #define DLSUFFIX ".so"
<command-line>: note: this is the location of the previous definition
The two definitions differ, because the one from the command line is
not a string. The warning is printed more than a hundred times in a
unittest-check run, and the command line value is never the one that is
used.
Quote the value, as src/backend/utils/fmgr/Makefile already does. The
two definitions are then the same, and there is no warning.
Checked with GCC 13 and GCC 15: the unquoted form warns, and the quoted
form does not.
Assisted-by: Claude Code
Backpatch-through: REL_2_STABLE
Member
Author
|
This change has been verified in Ubuntu 26.04 on #2096 |
yjhjstz
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every object of the backend unit tests is compiled with -DDLSUFFIX=.so, and pg_config.h then defines DLSUFFIX as ".so":
The two definitions differ, because the one from the command line is not a string. The warning is printed more than a hundred times in a unittest-check run, and the command line value is never the one that is used.
Quote the value, as src/backend/utils/fmgr/Makefile already does. The two definitions are then the same, and there is no warning.
Checked with GCC 13 and GCC 15: the unquoted form warns, and the quoted form does not.
Assisted-by: Claude Code
Backpatch-through: REL_2_STABLE
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions