Repository navigation
Conversation
With Perl 5.40 (Getopt::Long 2.57, as in Ubuntu 26.04), every run of gpdiff.pl prints a warning: Duplicate specification "verbose|Verbose" for option "verbose" It is printed more than a thousand times in a test run, and it reaches the test output. Getopt::Long ignores case by default and gpdiff.pl does not turn that off (it only sets pass_through), so "Verbose" is already matched by "verbose". Use "verbose" alone. Both -verbose and -Verbose still work. Checked on Ubuntu 26.04: the warning is gone with the new specification, and Ubuntu 24.04 (Getopt::Long 2.54) is not affected either way. Assisted-by: Claude Code Backpatch-through: REL_2_STABLE
Member
Author
|
This change has been verified in Ubuntu 26.04 on #2096 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Perl 5.40 (Getopt::Long 2.57, as in Ubuntu 26.04), every run of gpdiff.pl prints a warning:
It is printed more than a thousand times in a test run, and it reaches the test output.
Getopt::Long ignores case by default and gpdiff.pl does not turn that off (it only sets pass_through), so "Verbose" is already matched by "verbose". Use "verbose" alone. Both -verbose and -Verbose still work.
Checked on Ubuntu 26.04: the warning is gone with the new specification, and Ubuntu 24.04 (Getopt::Long 2.54) is not affected either way.
Assisted-by: Claude Code
Backpatch-through: REL_2_STABLE
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions