Conversation
|
|
||
| -- FDW test | ||
| CREATE SERVER hive_smoke_test_server | ||
| FOREIGN DATA WRAPPER hive_pxf_fdw |
Collaborator
There was a problem hiding this comment.
Could we keep this test until there is an FDW-enabled replacement? The existing Hive automation tests are not currently exercised in FDW mode: at the current PR head, the features_fdw report shows all 37 HiveTest cases as skipped. Removing this file therefore drops the end-to-end coverage that creates hive_pxf_fdw and reads from a real Hive table. Please port at least this basic Hive FDW read case to the automation or Testcontainers suite before deleting it.
Collaborator
Author
There was a problem hiding this comment.
Added this tests. Also, asked AI to enable all Hive + FDW tests that passes without code modifictiona.
| OPTIONS (resource '{{ HCFS_BUCKET }}{{ TEST_LOCATION }}', format 'csv'); | ||
|
|
||
| -- write to writable table | ||
| INSERT INTO multi_block_data_smoke_test_foreign_table |
Collaborator
There was a problem hiding this comment.
Could we port the write side of this test before deleting it? The new MultiBlockDataTest is not equivalent: it copies a generated file into HDFS and reads it through a ReadableExternalTable in the load group. It never performs this 32-million-row insert through FDW or checks the per-segment distribution. HdfsWritableTextTest exercises FDW writes, but only with 100 rows, so the large multi-block write path remains uncovered. Please retain this test or add an FDW-enabled large-write replacement.
Collaborator
Author
There was a problem hiding this comment.
I am not sure that this tests worked with Cloudberry...
--- features/hdfs/write_multi_block/output/query01_20260915090110708020.out 2026-09-15 09:02:21.763944773 +0100
+++ features/hdfs/write_multi_block/expected/query01.ans 2026-09-15 09:02:21.803943914 +0100
@@ -40,4 +41,7 @@
FROM pxf_multi_block_read
WHERE gp_segment_id = 0
) AS a;
-ERROR: cannot retrieve a system column in this context
It seems, that it never worked for cloudberry.
Collaborator
Author
There was a problem hiding this comment.
AI suggested workarond with WHERE gp_execution_segment() = 0
Collaborator
Author
|
@MisterRaindrop , could you please look at this PR? |
Collaborator
|
in CI I found some failed job https://github.com/apache/cloudberry-pxf/actions/runs/34988436326/job/106074565814 these failures were not reflected as failures and all seem to have succeeded. It may be necessary to verify whether the script contains bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two motivations behind this PR:
In this PR
/regression/tests (or move it to automation tests).