Repository navigation
Conversation
… option The `coverageWatermarks` option had no test. Run coverage with the HTML reporter using watermarks that classify any result as high (`[0, 0]`) or low (`[101, 101]`) and check the report's status class.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new test suite to verify the "coverageWatermarks" option in the unit-test builder, ensuring that coverage is correctly marked as "high" or "low" in the generated HTML report. The review feedback suggests removing an unnecessary "as any" type assertion on the "coverageReporters" option to maintain TypeScript's type safety.
MeAkib
force-pushed
the
test/unit-test-coverage-watermarks
branch
from
October 22, 2026 17:28
16a03fc to
9fa0f27
Compare
Collaborator
|
Thanks for the contribution! Closing this PR as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
coverageWatermarksoption had no test. Run coverage with the HTML reporter using watermarks that classify any result as high ([0, 0]) or low ([101, 101]) and check the report's status class.