[ako]

Closes #1645. Closes #1651 (mirror of mendixlabs#1642).

A name Mendix rejects passed check and exec, and only the build reported it. One commit per issue (plus one keeping CLAUDE.md within its byte budget).

#1645 — a member reusing a name on its generalization chain (CE0069)

Measured (mx 11.13.0, blank app, 21 cases). CE0069 for: attribute vs attribute, association vs association, attribute vs association both ways; a name two generalization levels up; System ancestors' members (System.User.Name, System.UserRoles, System.FileDocument.Size); downward — adding to a generalization a name its specialization already has; renaming an attribute or association into such a name; an entity's own attribute and own association sharing a name. An association's name belongs to its FROM entity, and under owner Both (reference and reference set) to the TO entity as well. Clean: names differing only in case (the comparison is exact), two siblings with the same name, an unrelated entity, an attribute on the TO end of an owner-Default association.

Cause: nothing checked a name against the chain. The only CE0069 guard (dropInheritedTargets, cmd_entities_bulk.go) looked inside the bulk ALTER ENTITIES target set; the single-statement paths (create entity, alter entity add/rename attribute, create association, rename association) compared only the entity's own attributes or the module's association names.

Fix: one verdict, memberNameClash (new member_name_clash.go), over a model of each entity's generalization and attributes plus each association's ends, walking self, ancestors (System included) and descendants.

• exec: each handler judges against the project before writing — create entity, alter entity add/rename attribute, create association, alter association set owner both, rename association; bulk ALTER ENTITIES judges every target before its first write.
• check -p: the reference pass replays the script in statement order over the project (otherwise a drop-then-re-add would be falsely refused, and a parent created after its child missed). check without a project: the same replay over the System module from modelsdk/meta, reported as MDL-MEMBER01.
• Only clashes the statement introduces are reported, so an unchanged create or modify re-run is not refused. The message names the member holding the name, its declaring entity, CE0069 and a fix.

Verified: PedApp check/exec agreement tests for every shape plus controls (member_name_clash_pedapp_test.go) and a project-free test. Reverted wiring: all nine tests fail, controls pass; reverting only the check pass fails check's half. A false positive found in final review (dropping an entity did not drop its associations in the replay) has a regression test. Real app: baseline 16× CE0069; fixed check and exec refuse those 16, the 5 clean cases are written, mx check 0 errors. Exec cost ≈ 8 ms per entity/association statement (137 calls added ≈ 1.1 s to the 23 s domain-model doctype exec).

#1651 — a page parameter named Context (CE7247)

Measured (~120 names × six contexts, mx 11.13.0): page, snippet, Java action and JavaScript action parameters follow exactly the existing types.PlatformReservedWords list — case-insensitive, quoted refused too. Every listed name gave CE7247; unlisted names were clean (incl. currentObject, latestError, latestHttpResponse, String, System, User, List, record). The exception: Object is CE7247 there and on an attribute, enumeration value and entity, but was missing from the list. The list does not apply to microflow/nanoflow parameters ($Context, $Type, $Class build clean) or page variables.

Cause: the list was applied only to attribute names (MDL021) and enumeration values (MDL010). Fix: new rule MDL-PARAM01 (validate_reserved_parameter_names.go) for create page/snippet, alter page/snippet add parameters, create java action, create javascript action — in ValidateProgram (check and exec's preflight) and in the five exec handlers, so --no-check cannot write it either; the suggested rename is the parameter's entity name. object added to the shared list (MDL021 and MDL010 now catch it too).

Verified: unit tests per context, with controls (non-reserved name, a system-variable name, microflow/nanoflow parameters); a PedApp check/exec agreement test; reverted wiring fails all. Real app: the 61 probe scripts baseline mx check flagged with CE7247 (62 parameters) plus the reporter's page are refused; the other 109 are written at 0 errors; the reporter's workaround $LaneContext is accepted.

All

• No regressions: all 81 non-.fail doctype scripts give identical output on main and fixed, with and without -p; domain-model doctype scripts exec identically; 650 related bug-test and skill scripts give identical check results.
• Full go test ./... (incl. the CLAUDE.md budget test), go vet, gofmt; CI's doc checks pass locally. Bug-tests member-name-1645-inherited-attribute.fail.mdl, member-name-1645-inherited-association.fail.mdl, page-params-1651-reserved-context.fail.mdl; findings recorded; generate-domain-model and create-page skills, docs-site create-entity / create-page; CLAUDE.md's reserved-names note (Object, MDL-PARAM01, the list's location in mdl/types/reserved_words.go).
• Not verified: -tags integration doctype mx-check runs.

Noticed, not fixed

1. Microflow/nanoflow parameters and variables named with system-variable names pass check and exec and mxbuild rejects them: CE0110 for currentObject, latestError (both flow kinds), latestHttpResponse, latestSoapFault, currentSession, currentDeviceType as microflow parameters/variables; CE0039 for a microflow variable CurrentUser and nanoflow variables CurrentUser, currentDeviceType, currentSession, latestHttpResponse.
2. Entity names are not checked against the reserved list (Object measured CE7247).
3. reservedEntityAttrNames (cmd_contract.go, OData import auto-rename) is a separate, narrower list without object and the Java keywords (not measured).
4. From reading only: in execCreateAssociation, a create or modify for an association that exists in the other list (same-module vs cross-module) falls through and creates a second association of the same name.

🤖 Generated with Claude Code