[ako]

Closes #1683. Closes #1700 (mirror of mendixlabs#1653). Closes #1702 (mirror of mendixlabs#1658).

Three issues, one commit each.

#1683 — log / send email stored an expression followed by with (…) as its source text

log info node 'P' $Msg with ({1} = 'x'); logged the literal $Msg; Subject: $Subj with ({1} = '42') sent $Subj — check, exec and mx check all passed. Cause (cmd_microflows_builder_calls.go): addLogMessageAction and emailTemplate stored fb.exprToString(message) as the template text. show message and validation feedback had the same shape broken differently — they stored '{1}' with $Msg as its parameter and appended the stated ones, so 'x' became a {2} nothing reads and the message showed its own unfilled {1}.

Fix: one shared decision, messageTemplateRefusals (new message_templates.go), rule MDL-TEMPLATE01: an expression followed by with (…) (or the deprecated objects [...]) is refused on log, send email (subject, body, HtmlBody), show message and validation feedback — all four builders call it (exec refuses), and check reports it from the microflow, nanoflow, alter-fragment and rule validators. An expression has no {n} for with to fill; the same rule as MDL-REST05 (#1669) and MDL-JA02 (#1692). Sibling fixed: a multi-line email Body: string literal with parameters stored its source, quotes included, as the template; it now stores the literal's value. Kept inside the template paths (PR #1731 touches the call builders/grammar).

Verified: message_templates_test.go (check and exec on every statement and flow kind, controls, the multi-line body; reverted: every refused case and the body case fail). 11.13.0: before, all four flows written and mx check 0 errors; after, check and exec --no-check refuse with nothing written; the control forms build at 0 errors.

#1700 — the generated .java file lacked the class javadoc

Cause: sdk/javaactions/source.go GenerateSource took no documentation. Fix: GenerateSource / WriteJavaSourceFile take it; the executor passes the action's carried documentation, so create or modify without a doc comment keeps the block. The format was measured against mxbuild 11.13.0: \r\n, \r and \n each end a * line; whitespace kept (whitespace-only documentation still gets a block); a backslash is doubled unless u/U + four hex digits follow (the upstream proposal missed this); mxbuild rejects */ in documentation as a model error, which an MDL doc comment cannot produce.
Verified: 14 goldens from a real mxbuild deploy build (sdk/javaactions/testdata/mxbuild/JA_Doc*.java.golden, CRLF preserved) reproduced byte for byte; reverted, all but the no-documentation control fail. Real app, 15 actions create or modifyd over mxbuild's files: 13/15 byte-identical (baseline 1/15; the other 2 differ only in mxcli's long-standing user-code blank-line padding), and the next mxbuild build rewrote 0/15 files (baseline 14/15).

#1702 — no EXTRA CODE clause, so describe → exec lost hand-written helpers

Cause: the grammar ended create java action at AS $$ … $$ (the AST already had an unset ExtraCode), and describe read only the USER CODE section. New clause:

create or modify java action ModJ.JA_Twice(N: Integer not null) returns Integer
as $$
import java.util.Objects;
return twice(N);
$$
extra code $$
private static long twice(long n) { return Objects.requireNonNull(n) * 2L; }
$$;

extra code $$ … $$ sets the EXTRA CODE section (blank lines at either end trimmed; an import line inside it moves to the import list, as in the body); omitted keeps the stored section (like EXPOSED AS); extra code $$ $$ clears it. Describe prints it, plus the shortest leading part of the import list that regenerates the stored list in order. EXTRA and CODE are new keywords, both in the keyword rule (a test shows Code still works as an attribute name).
Verified: visitor/sdk/executor tests — describe → exec rebuilds the report's file byte for byte; leaving the clause out hands the writer nil (keep). Reverted: all fail. Real app: baseline replay lost the import and the helper and mxbuild failed cannot find symbol; fixed replay is byte-identical, builds, and the build leaves it unchanged. Doctype example in 07-java-action-examples.mdl passes -tags integration exec + mx check (0 errors).

All

Full go test ./... (incl. the conformance gate), go vet, gofmt; CI's doc checks pass locally. Repros: log-email-1683-expression-with-params.fail.mdl, the #1700 and java-action-1702-extra-code-roundtrip.mdl bug-tests. Findings recorded. Docs: mxcli syntax (logging, send-email, validation, java-action.create), MDL_QUICK_REFERENCE.md, write-microflows pitfalls §16, java-actions skill, docs-site create-java-action.md and error appendix.

Noticed, not fixed

• JavaScript actions have the same EXTRA CODE round-trip gap (describe prints it only as a comment; WriteJavaScriptSourceFile has no extra-code parameter).
• TUI preview stripJavaCodeBlock looks for "\nAS $$" but describe prints lowercase as $$.
• A $$ inside Java code ends the dollar string (body and extra code alike); documentation containing // BEGIN USER CODE would confuse section extraction.

🤖 Generated with Claude Code