Repository navigation
fix(league): refine tasks and repair navigation and grading - #200
Merged
Merged
Conversation
# Conflicts: # sites/league_of_legends/tasks.jsonl
QianhuiWu
changed the base branch from
orch/integrate/league_of_legends
to
main
September 23, 2026 19:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The champion roster's Newest order used internal asset IDs, mobile navigation disappeared, and verifier tests could silently skip on another machine. This continuation of #195 replaces that order with Most skins, restores mobile navigation, makes ability/skin controls keyboard accessible, constrains account return URLs, and repairs narrow-screen layouts.
Refines 21 shallow tasks plus clarifies one patch comparison, with coherent champion-learning and patch-analysis goals, matching rubrics, and entity-scoped verifiers. Signup grading now checks submitted identity and password data. All 30 task recordings complete in at least six meaningful actions; efficient correct solutions are still accepted.
Validation: 327 site/verifier tests and 5 additional signup controls passed; 30/30 scripted visible-UI tasks pass the official deterministic grader. Combined review of #194/#195 includes 703 expected grading-control outcomes, a fresh fetch from merged HF #120/#121 at
d8753ff2e7b199a94e35e4b069c0765e999ec331, full Docker build with the final mobile CSS verified against source, both-site readiness/homepage/reset/restart and seed-contract checks, and all 79 registry ports. League uses 40078; existing ports are preserved. Unchanged HF archives were merged while preserving unrelated assets.Evidence:
/data/pr194-195-review, GIF dashboard athttp://localhost:45103/(requires forwarding port 45103). Recordings use source-informed reference answers, not independent agent attempts. Lexical graders have bounded paraphrase coverage; the secondary LLM judge was not run. No image publication or deployment.Merge after #195, following #194 and its reviewer continuation, preserving original contribution ancestry.