Skip to content

fix(cli): the taught backlog example is pinned harder than the reader requires #973

Closed as not planned

Description

@blafourcade

Description

cli/tests/contexts/telemetry/infrastructure/task-backlog-skill-shape.integration.test.ts asserts more about the taught backlog-link.json example than the reader requires, and no gate runs it when only the taught plugin files change.

  • :71 pins the value: expect(declaration.link.backlog).toBe("owner/repo#123").
  • :88 demands the two teaching files carry identical key sets.
  • lefthook.yml's pre-push cli-knip and cli-test carry glob: "cli/**". .github/workflows/cli-ci.yml:70 matches cli/*|kanban/*|scripts/__tests__/*|README.md plus plugins/aidd-telemetry/* minus prose. Neither covers plugins/aidd-pm/** or plugins/aidd-dev/**.

So two edits confined to plugin files commit locally and land a red test on next.

Affected file(s)

cli/tests/contexts/telemetry/infrastructure/task-backlog-skill-shape.integration.test.ts

Expected behaviour

The test asserts what the reader accepts and no more. The reader takes any non-empty string for all three fields (cli/src/contexts/telemetry/infrastructure/task-backlog-adapter.ts:12-14), so a changed placeholder value is not a defect. Where an assertion is stronger than the reader on purpose, it is the kind a guard watched on plugins/** can carry.

Observed behaviour

Measured on fix/backlog-shape-guard, both on plugins-only edits:

  • changing the taught backlog to owner/repo#999 → the scripts guard passes, the sibling fails with expected 'owner/repo#999' to be 'owner/repo#123';
  • adding a fourth field to one taught file only → the scripts guard passes, the sibling fails on key-set equality.

AI tool

Claude Code

OS

macOS

Additional context

Surfaced by #972, which closed the same class for the structural assertions by moving them into scripts/__tests__/a-backlog-link-the-reader-can-read.test.js, the guard whose glob covers plugins/**. Its plan deferred these two assertions because #972 scopes its Affected file to the scripts guard.

Widening either filter to plugins/** is the wrong fix: it runs the full cli suite on every prose edit.

Activity

  1. added theissue type on Oct 7, 2026
  2. blafourcade commented on Oct 15, 2026

    @blafourcade
    ContributorAuthor

    Superseded by #993: the backlog example and its reader were removed.

  3. moved this from Ideation to Done in AIDD Roadmapon Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    None yet

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions