Skip to content

Pass a full-width size_t to the compat setparam/getparam #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
herniqeu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pass a full-width size_t to the compat setparam/getparam #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10bd436
Pass a full-width size_t to the compat setparam/getparam
herniqeu Nov 1, 2026
29b292f
Test that compat setparam/getparam keep 64-bit values
herniqeu Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions magic/compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def getparam(self, param):
Returns the param value if successful and -1 if the parameter
was unknown.
"""
v = c_int()
v = c_size_t()
i = _getparam(self._magic_t, param, byref(v))
if i == -1:
return -1
Expand All @@ -254,7 +254,7 @@ def setparam(self, param, value):
"""
Returns 0 if successful and -1 if the parameter was unknown.
"""
v = c_int(value)
v = c_size_t(value)
return _setparam(self._magic_t, param, byref(v))


Expand Down
8 changes: 8 additions & 0 deletions test/python_magic_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,14 @@ def test_version(self):
except NotImplementedError:
pass


def test_compat_params_use_size_t(self):
# libmagic reads and writes setparam/getparam values as a size_t,
# so the compat module must not truncate them to 32 bits.
m = magic.compat.open(magic.compat.MAGIC_NONE)
self.assertEqual(0, m.setparam(magic.compat.PARAM_BYTES_MAX, 2**33))
self.assertEqual(2**33, m.getparam(magic.compat.PARAM_BYTES_MAX))

def test_fs_encoding(self):
self.assertEqual("utf-8", sys.getfilesystemencoding().lower())

Expand Down