Repository navigation
fix(acp): redact payload-bearing errors in warning logs - #433
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses SDK-2: malformed parameters could enter ordinary warning logs through
Error.data.jsonand payload-bearing Serde parse reasons.Privacy boundary
This implements the redacted-WARN formatter option. Returned and wire errors remain unchanged and potentially sensitive, including full failing input JSON. Explicitly enabled DEBUG/TRACE diagnostics remain unchanged. Field paths are not extracted from free-form error text because the current errors do not expose a separately trusted structured path.
Validation
just test(workspace all-features tests/doctests and core no-default-features tests)cargo clippy -p agent-client-protocol --all-features --tests --locked -- -D warningscargo fmt --all -- --checkgit diff --checkmdbook buildaftermdbook-mermaid install .(non-blocking preprocessor version mismatch warning)