Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3661
Fix
build.includesset, LESS files placed directly in a plugin'sless/plugins/folder (e.g.less/plugins/speed.less) are now compiled. Previously any path containing/less/pluginswas treated as a nested plugin-specific folder, and the file was dropped silently becausespeed.lessis not a folder named after an included plugin.less/plugins/<plugin>/subfolder, so plugin-specific styles such as vanilla'sless/plugins/adapt-contrib-gmcq/are still left out when that plugin is not included.Testing
.lessfile with a unique selector directly in an included plugin'sless/plugins/folder, e.g.src/components/adapt-contrib-media/less/plugins/test.less.build.includesto the plugins in use, leaving out one plugin that vanilla has aless/plugins/<plugin>/folder for (e.g.adapt-contrib-gmcq).grunt devand search build/adapt.css for the selectors:less/plugins/test.lessselector is present (missing before this fix).less/plugins/<included-plugin>/folders are present.less/plugins/<excluded-plugin>/folder are absent.build.includesand rebuild: all of the above are present, as before.Tested on v5.56.3.
Posted via collaboration with Claude Code