Repository navigation
Conversation
dhalbert
left a comment
There was a problem hiding this comment.
Let's called this airlift and AIRLIFT everywhere instead of nina and NINA. That's what I was doing in #10786, which I stopped working on. Yes, it's our fork of NINA, but it might not be some day.
Is there room for this to fit on, say, a PyPortal? Might we eventually have another version of ESP32SPI that uses _airlift?
|
I will rename to I haven't looked at anything outside the Fruit Jam yet, I'll check into pyportal to see if this could work on there. The existing ESP32SPI will need to get updated to make it use the new When the core doesn't own the co-processor (web_workflow not enabled) the existing ESP32SPI works as-is. Only the case where web workflow is enabled and the core owns the ESP32 needs updating to use the new API. |
Could we use |
|
@dhalbert after exploring this some I do think it's plausible to use The size situation is tricky. ESP32SPI can get smaller if it loses fallback support for working without If ESP32SPI keeps fallback logic to work without |
|
Maybe the fallback transport support could be moved to a new library instead of a new module within ESP32SPI. Then ESP32SPI gets smaller, and only the boards that want to use airlift without being able to fit That could be awkward to explain on support side perhaps. Hopefully the error messages could make it clear when that extra library is needed. |
|
I updated this in the latest commit to allow user passed pins for init. |
A new core module
_ninaimplements transport and framing for communication with ESP32 co-processor. If used the core owns the ESP32 pins including the reset pin, which on the Fruit Jam is PERIPH_RESET and also resets the TLV320.If this change is accepted ESP32SPI library needs updated to use the new APIs when the core owns the co-processor. I will submit a PR there with that functionality.
Python code continues to use ESP32SPI library for WIFI access.
Web workflow uses
_ninainternally to serve the workflow server. It does not currently support mDNS so it is available by IP only, notcircuitpython.localor the UUID .local address.I have tested the file browser and websocket serial connection fairly extensively over the last few days. Have not tested local or code.circuitpython.org code editor pages.