Report SpinLock contention from the acquiring thread as well. - #1430
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
SpinLock contention was only observable from the releasing side: SpinLock::SlowUnlock reports the releaser's own quantized acquisition wait via RegisterSpinLockProfiler, so the stack that actually waited was never recorded. Add RegisterSpinLockLockProfiler, invoked at the end of SpinLock::SlowLock on the acquiring thread while it holds the lock, with the full-precision wait in cycles. This parallels absl::Mutex, which reports contention from both the lock and unlock paths. PiperOrigin-RevId: 984216001
copybara-service
Bot
force-pushed
the
test_984216001
branch
from
September 20, 2026 03:11
8a9d31a to
62ee4f3
Compare
copybara-service
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report SpinLock contention from the acquiring thread as well.
SpinLock contention was only observable from the releasing side:
SpinLock::SlowUnlock reports the releaser's own quantized acquisition wait via
RegisterSpinLockProfiler, so the stack that actually waited was never
recorded. Add RegisterSpinLockLockProfiler, invoked at the end of
SpinLock::SlowLock on the acquiring thread while it holds the lock, with the
full-precision wait in cycles. This parallels absl::Mutex, which reports
contention from both the lock and unlock paths.