Skip to content

y-build TLS support #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solsson merged 1 commit into from
Oct 5, 2026
Merged

y-build TLS support #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions bin/y-build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ set -eo pipefail
# --format <oci|tarball> format for --output, as in crane pull --format (default oci)
# --tarball <path> shorthand for --output <path> --format tarball
# --push=false skip push to registry
# Env BUILDKIT_HOST selects buildkitd (default: ystack's in-cluster one), and BUILDKIT_TLS_DIR
# its TLS client files (see y-buildctl).
BUILDCTL_OPTS=""
FILE_OUTPUT=""
OUTPUT_PATH=""
Expand Down Expand Up @@ -155,6 +157,10 @@ fi
DEFAULT_REGISTRY=builds-registry.ystack.svc.cluster.local
[ -z "$BUILDS_REGISTRY" ] && BUILDS_REGISTRY=$DEFAULT_REGISTRY
[ -z "$PUSH_REGISTRY" ] && PUSH_REGISTRY=$DEFAULT_REGISTRY
if [ -z "$BUILDKIT_HOST" ] && [ -n "$BUILDKIT_TLS_DIR" ]; then
echo "ERROR BUILDKIT_TLS_DIR is set but BUILDKIT_HOST is not; ystack's in-cluster buildkitd has no TLS" >&2
exit 1
fi
if [ -z "$BUILDKIT_HOST" ]; then
BUILDKIT_HOSTNAME=buildkitd.ystack.svc.cluster.local
# Prefer port 80 (Gateway API) for local clusters, fall back to 8547 (y-kubefwd for remote clusters)
Expand Down
4 changes: 4 additions & 0 deletions bin/y-buildctl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,8 @@ YBIN="$(dirname $0)"

version=$(y-bin-download $YBIN/y-bin.runner.yaml buildctl)

# buildctl takes TLS client files only as flags; BUILDKIT_HOST is its only env.
# BUILDKIT_TLS_DIR holds ca.pem, cert.pem and key.pem, the layout of DOCKER_CERT_PATH.
[ -z "$BUILDKIT_TLS_DIR" ] || set -- --tlsdir "$BUILDKIT_TLS_DIR" "$@"

y-buildctl-v${version}-bin "$@" || exit $?
Loading