Repository navigation
Warn on apply with removed keys, keep ignoring them in drivers - #11
Merged
Merged
Conversation
The kadm driver applies the config.* keys in spec.parameters and never reverts one that is removed: an omitted parameter means "pass nothing", and what a broker does with a deleted topic override (its default, a broker-level setting, whatever its version decides) is not something the controller can predict. The topic keeps the value last applied, unmanaged. Nothing said so, and nothing could: the driver only sees the current parameters. The admission webhook sees the old and the new object on every update. When the merged view (backend defaults included, so a key falling back to a default does not count) loses a config.* key, the update is allowed with an admission warning naming the keys, which kubectl apply prints, and the webhook logs the same message once per apply (not for server dry runs such as kubectl diff). Driver-known keys are unaffected; config.* is SPEC's pass-through category, used by kadm only today. With the webhook disabled there is no warning. README (kadm) says how to go back to the broker default; SPEC "Parameters" states the non-revert rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scripts/bump-release.sh with the go.mod toolchain (go1.27.1). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have no well defined behavior for when a config key is removed at apply. It causes no config change. Now it logs a warning if webhook is enabled.