Skip to content

Finished some todos - #177

Merged
windcolor-dev merged 4 commits into
Wind-Development:masterfrom
xii69:master
Oct 5, 2026
Merged

windcolor-dev merged 4 commits into
Wind-Development:masterfrom
xii69:master

Conversation

@xii69

@xii69 xii69 commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Added hasEnchantments method for better code style
Throwing an exception instead of replacing the given value with the maximum / minumum allowed in Vanilla commands
Added configuration options for NachoSpigot commands

Throwing an exception instead of replacing the given value with the maximum / minumum allowed in Vanilla commands
Added configuration options for NachoSpigot commands

@windcolor-dev windcolor-dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good!

Comment thread WindSpigot-API/src/main/java/org/bukkit/command/defaults/EnchantCommand.java Outdated
Comment thread WindSpigot-API/src/main/java/org/bukkit/command/defaults/EnchantCommand.java Outdated
Comment thread WindSpigot-API/src/main/java/org/bukkit/inventory/ItemStack.java Outdated
Comment thread WindSpigot-API/src/main/java/org/bukkit/inventory/ItemStack.java Outdated
@kalibrieren

Copy link
Copy Markdown
Contributor

More important To-Dos to finish than this - for this one you could/should remove the comment

@xii69

xii69 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

More important To-Dos to finish than this - for this one you could/should remove the comment

Yes, I had a few more changes in mind to make. Will this change be merged?

Also, could you list the more important TODOs so I can work on them in priority order?

@kalibrieren

Copy link
Copy Markdown
Contributor

More important To-Dos to finish than this - for this one you could/should remove the comment

Yes, I had a few more changes in mind to make. Will this change be merged?

Also, could you list the more important TODOs so I can work on them in priority order?

Probably won't be merged as (I don't think) it was added in modern versions?

For the TODOs: just search them from the codebase or something, your IDE can surely do that :)

@windcolor-dev

Copy link
Copy Markdown
Member

More important To-Dos to finish than this - for this one you could/should remove the comment

Yes, I had a few more changes in mind to make. Will this change be merged?

Also, could you list the more important TODOs so I can work on them in priority order?

I added some changes you can click to apply

xii69 and others added 2 commits October 4, 2026 21:50
…ntCommand.java

Co-authored-by: windcolor-dev <79166388+windcolor-dev@users.noreply.github.com>
Co-authored-by: windcolor-dev <79166388+windcolor-dev@users.noreply.github.com>
@xii69

xii69 commented Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

Hey, I've been away for a while, back right now
I'll try to do more TODOs in my free time
It will be way better if you point the ones more important

@xii69
xii69 requested a review from windcolor-dev October 5, 2026 12:28
@windcolor-dev

Copy link
Copy Markdown
Member

Hey, I've been away for a while, back right now I'll try to do more TODOs in my free time It will be way better if you point the ones more important

Looks good, thanks for the PR!

One thing I have been considering but that I haven't gotten around to is implementing PaperServerListPingEvent

@windcolor-dev
windcolor-dev merged commit 283c604 into Wind-Development:master Oct 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants