Repository navigation
Finished some todos - #177
Conversation
Throwing an exception instead of replacing the given value with the maximum / minumum allowed in Vanilla commands Added configuration options for NachoSpigot commands
windcolor-dev
left a comment
There was a problem hiding this comment.
Other than that, looks good!
|
More important To-Dos to finish than this - for this one you could/should remove the comment |
Yes, I had a few more changes in mind to make. Will this change be merged? Also, could you list the more important TODOs so I can work on them in priority order? |
Probably won't be merged as (I don't think) it was added in modern versions? For the TODOs: just search them from the codebase or something, your IDE can surely do that :) |
I added some changes you can click to apply |
…ntCommand.java Co-authored-by: windcolor-dev <79166388+windcolor-dev@users.noreply.github.com>
Co-authored-by: windcolor-dev <79166388+windcolor-dev@users.noreply.github.com>
|
Hey, I've been away for a while, back right now |
Looks good, thanks for the PR! One thing I have been considering but that I haven't gotten around to is implementing |
Added hasEnchantments method for better code style
Throwing an exception instead of replacing the given value with the maximum / minumum allowed in Vanilla commands
Added configuration options for NachoSpigot commands