[valzargaming]

Summary

Follow-up to #38. After deploying #38 (5c6e2b8) the portable bot still died within 3 minutes with a player connected:

PHP Fatal error:  Uncaught Civ13\Exceptions\VerifierException: Hosted verification unavailable in src/Civ13/Verifier.php:1187
#0 src/Civ13/Verifier.php(1052): Civ13\Verifier->get('ss13', 'valzargaming')
#1 src/Civ13/Civ13.php(1889): Civ13\Verifier->getVerifiedItem('valzargaming')
#2 src/Civ13/Moderator.php(138): Civ13\Civ13->ckeyinfo('valzargaming')
#3 src/Civ13/GameServer.php(510): Civ13\Moderator->scrutinizeCkey('valzargaming')

scrutinizeCkey() also reaches Verifier::get() through Civ13::ckeyinfo(), and the serverinfo timer is a plain loop timer, so any throw is fatal.

• GameServer::serverinfoTimer(): catch any \Throwable per ckey and log a warning, so one player's check can never kill the bot.
• GameServer::createCurrentRoundEmbedMessageBuilder(): the verified-player list called Verifier::get() inside array_map; while verification is unavailable it threw and the round embed was never built (Could not create a MessageBuilder for test1714). Omit that list instead.

Testing

• php -l src/Civ13/GameServer.php: no syntax errors.
• No automated test (GameServer needs a full Civ13 instance). Live check after merge: portable bot stays up across several 180 s serverinfo cycles with a player connected and hosted verification unavailable.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Server status updates now continue when an individual player’s information cannot be checked, so one issue is less likely to interrupt processing.
  • Round summaries can still be generated when verified-player details are unavailable; in that case, the verified-player list is omitted.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The server info timer now handles exceptions from player scrutiny by logging a warning and continuing. The round embed builder handles verified-player lookup failures and omits the verified-player field when no IDs are available.

Changes: Verifier failure handling

Layer / File(s)	Summary
Handle verifier failures src/Civ13/GameServer.php	The timer logs the ckey and exception message when scrutiny throws. The embed builder catches VerifierException and adds the verified-player field only when the lookup returns IDs.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

• Valgorithms/Civilizationbot#38: Catches VerifierException in Moderator::scrutinizeCkey; this PR handles related failure paths in GameServer.

Merge Risk: Moderate · up to ae9d2

The change keeps the bot and round embed running when verification is unavailable. However, a player who connects during a verification outage is marked as already checked, so alt-ban and IP checks are skipped for them until the bot restarts. Record the player as seen only after the first-time checks finish.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}