Repository navigation
Keep Model Target allowance policy in the real adapter - #3764
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared Model Target status helper currently recognizes the Vuforia hostname to skip allowance rejections and xfails those rejections at other URLs. This embeds real-account policy in the shared assertions and can hide an unexpected rejection from a mock.
Keep the shared status assertion strict by default, retaining the URL, status and body in its diagnostics. Add a typed, scoped response-handler operation for adapters. Only the real Model Target adapter installs the allowance handler, preserving its skip reason and supporting supplied URLs without hostname inference. Expected error statuses still pass, and unrelated failures still raise.
Part of #3738.
Validation:
git diff --check.